You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/26 03:50:36 UTC

[GitHub] [airflow] Marloxo opened a new issue #9526: remove duplicate parameters from `sql_to_gcs.py`

Marloxo opened a new issue #9526:
URL: https://github.com/apache/airflow/issues/9526


   **Apache Airflow version**:
   1.10.10
   
   **Environment**:
   Docker
   
   **What happened**:
   
   it's just small nitpick, we have this redundant line which assign the `parameters` twice in `sql_to_gcs` 
   
   https://github.com/apache/airflow/blob/master/airflow/providers/google/cloud/transfers/sql_to_gcs.py#L115:L118
   
   ```python
           self.parameters = parameters
           self.gcp_conn_id = gcp_conn_id
           self.delegate_to = delegate_to
           self.parameters = parameters
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil closed issue #9526: remove duplicate parameters from `sql_to_gcs.py`

Posted by GitBox <gi...@apache.org>.

kaxil closed issue #9526:
URL: https://github.com/apache/airflow/issues/9526


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on issue #9526: remove duplicate parameters from `sql_to_gcs.py`

Posted by GitBox <gi...@apache.org>.

kaxil commented on issue #9526:
URL: https://github.com/apache/airflow/issues/9526#issuecomment-651450369


   Fixed by https://github.com/apache/airflow/pull/9527


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org