You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by francois92 <gi...@git.apache.org> on 2016/01/04 17:19:08 UTC
[GitHub] wicket pull request: examples7x.wicket.apache.org/resourceaggregat...
GitHub user francois92 opened a pull request:
https://github.com/apache/wicket/pull/154
examples7x.wicket.apache.org/resourceaggregation generate Internal error
https://issues.apache.org/jira/browse/WICKET-6065
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/francois92/wicket master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
----
commit 3d44f5593988eddbfba5bde6f986b87ced82483a
Author: fmt <az>
Date: 2016-01-04T16:16:30Z
examples7x.wicket.apache.org/resourceaggregation generate Internal error
https://issues.apache.org/jira/browse/WICKET-6065
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: examples7x.wicket.apache.org/resourceaggregat...
Posted by francois92 <gi...@git.apache.org>.
Github user francois92 closed the pull request at:
https://github.com/apache/wicket/pull/154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: examples7x.wicket.apache.org/resourceaggregat...
Posted by bitstorm <gi...@git.apache.org>.
Github user bitstorm commented on the pull request:
https://github.com/apache/wicket/pull/154#issuecomment-169041812
@francois92 could you please close this PR? The problem has been fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] wicket pull request:
examples7x.wicket.apache.org/resourceaggregat...
Posted by Andrea Del Bene <an...@gmail.com>.
Examples should be ok now. I will close the PR on github.
Andrea.
>
> ok, I'll take a look today
>
> On 5 Jan 2016 12:27, "Martin Grigorov" <mgrigorov@apache.org
> <ma...@apache.org>> wrote:
>
> This sounds as a regression caused by 950df6c24196680a48646ff92b3d95
> 9f4985a238
>
> @Andrea: could you please investigate and either improve further
> or revert
> the change? Thanks!
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Tue, Jan 5, 2016 at 12:14 PM, Francois Meillet <
> francois.meillet@gmail.com <ma...@gmail.com>> wrote:
>
> > if the CachingStrategy is FilenameWithVersionResourceCachingStrategy
> > (default)
> >
> > BasicResourceReferenceMapper # mapHandler
> > --> getCachingStrategy().decorateUrl(resourceUrl,
> cacheable);
> > --> FilenameWithVersionResourceCachingStrategy #
> > decorateUrl()
> > --> CachingResourceVersion # getVersion()
> > --> resource.getCacheKey()
> > --> ConcatBundleResource #
> > getCacheKey()
> > -->
> PackageResource #
> > getCacheKey() has been modified in the commit
> > 950df6c24196680a48646ff92b3d959f4985a238 "Improved
> > PackageResource#getCacheKey" done on the 3/1/2016
> > -->
> > PackageResource # exists()
> >
> > String absolutePath = Packages.absolutePath(scope, path) is wrong
> >
> > for the footer.css the absolutePath is
> >
> >
> org/apache/wicket/examples/resourcedecoration/org/apache/wicket/examples/resourcedecoration/footer.css
> > --> then
> > ConcatBundleResource # getCacheKey() return null
> > -->
> > ConcatBundleResource # reportError is called
> >
> > With the NoOpResourceCachingStrategy, decorateUrl does nothing,
> so there
> > is no problem.
> >
> > Francois
> >
> >
> >
> >
> >
> >
> > Le 5 janv. 2016 à 09:58, martin-g <git@git.apache.org
> <ma...@git.apache.org>> a écrit :
> >
> > > Github user martin-g commented on the pull request:
> > >
> > > https://github.com/apache/wicket/pull/154#issuecomment-168938119
> > >
> > > It is interesting to find how this got broken.
> > > Do you have time to `git bisect` it ?
> > > I'll be able to do it as soon as next week.
> > >
> > >
> > > ---
> > > If your project is set up for it, you can reply to this email
> and have
> > your
> > > reply appear on GitHub as well. If your project does not have this
> > feature
> > > enabled and wishes so, or if the feature is enabled but not
> working,
> > please
> > > contact infrastructure at infrastructure@apache.org
> <ma...@apache.org> or file a JIRA
> > ticket
> > > with INFRA.
> > > ---
> >
> >
>
Re: [GitHub] wicket pull request: examples7x.wicket.apache.org/resourceaggregat...
Posted by Andrea Del Bene <an...@gmail.com>.
ok, I'll take a look today
On 5 Jan 2016 12:27, "Martin Grigorov" <mg...@apache.org> wrote:
> This sounds as a regression caused by 950df6c24196680a48646ff92b3d95
> 9f4985a238
>
> @Andrea: could you please investigate and either improve further or revert
> the change? Thanks!
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Tue, Jan 5, 2016 at 12:14 PM, Francois Meillet <
> francois.meillet@gmail.com> wrote:
>
> > if the CachingStrategy is FilenameWithVersionResourceCachingStrategy
> > (default)
> >
> > BasicResourceReferenceMapper # mapHandler
> > --> getCachingStrategy().decorateUrl(resourceUrl, cacheable);
> > --> FilenameWithVersionResourceCachingStrategy #
> > decorateUrl()
> > --> CachingResourceVersion # getVersion()
> > --> resource.getCacheKey()
> > --> ConcatBundleResource #
> > getCacheKey()
> > --> PackageResource #
> > getCacheKey() has been modified in the commit
> > 950df6c24196680a48646ff92b3d959f4985a238 "Improved
> > PackageResource#getCacheKey" done on the 3/1/2016
> > -->
> > PackageResource # exists()
> >
> > String absolutePath = Packages.absolutePath(scope, path) is wrong
> >
> > for the footer.css the absolutePath is
> >
> >
> org/apache/wicket/examples/resourcedecoration/org/apache/wicket/examples/resourcedecoration/footer.css
> > --> then
> > ConcatBundleResource # getCacheKey() return null
> > -->
> > ConcatBundleResource # reportError is called
> >
> > With the NoOpResourceCachingStrategy, decorateUrl does nothing, so there
> > is no problem.
> >
> > Francois
> >
> >
> >
> >
> >
> >
> > Le 5 janv. 2016 à 09:58, martin-g <gi...@git.apache.org> a écrit :
> >
> > > Github user martin-g commented on the pull request:
> > >
> > > https://github.com/apache/wicket/pull/154#issuecomment-168938119
> > >
> > > It is interesting to find how this got broken.
> > > Do you have time to `git bisect` it ?
> > > I'll be able to do it as soon as next week.
> > >
> > >
> > > ---
> > > If your project is set up for it, you can reply to this email and have
> > your
> > > reply appear on GitHub as well. If your project does not have this
> > feature
> > > enabled and wishes so, or if the feature is enabled but not working,
> > please
> > > contact infrastructure at infrastructure@apache.org or file a JIRA
> > ticket
> > > with INFRA.
> > > ---
> >
> >
>
Re: [GitHub] wicket pull request: examples7x.wicket.apache.org/resourceaggregat...
Posted by Martin Grigorov <mg...@apache.org>.
This sounds as a regression caused by 950df6c24196680a48646ff92b3d95
9f4985a238
@Andrea: could you please investigate and either improve further or revert
the change? Thanks!
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Tue, Jan 5, 2016 at 12:14 PM, Francois Meillet <
francois.meillet@gmail.com> wrote:
> if the CachingStrategy is FilenameWithVersionResourceCachingStrategy
> (default)
>
> BasicResourceReferenceMapper # mapHandler
> --> getCachingStrategy().decorateUrl(resourceUrl, cacheable);
> --> FilenameWithVersionResourceCachingStrategy #
> decorateUrl()
> --> CachingResourceVersion # getVersion()
> --> resource.getCacheKey()
> --> ConcatBundleResource #
> getCacheKey()
> --> PackageResource #
> getCacheKey() has been modified in the commit
> 950df6c24196680a48646ff92b3d959f4985a238 "Improved
> PackageResource#getCacheKey" done on the 3/1/2016
> -->
> PackageResource # exists()
>
> String absolutePath = Packages.absolutePath(scope, path) is wrong
>
> for the footer.css the absolutePath is
>
> org/apache/wicket/examples/resourcedecoration/org/apache/wicket/examples/resourcedecoration/footer.css
> --> then
> ConcatBundleResource # getCacheKey() return null
> -->
> ConcatBundleResource # reportError is called
>
> With the NoOpResourceCachingStrategy, decorateUrl does nothing, so there
> is no problem.
>
> Francois
>
>
>
>
>
>
> Le 5 janv. 2016 à 09:58, martin-g <gi...@git.apache.org> a écrit :
>
> > Github user martin-g commented on the pull request:
> >
> > https://github.com/apache/wicket/pull/154#issuecomment-168938119
> >
> > It is interesting to find how this got broken.
> > Do you have time to `git bisect` it ?
> > I'll be able to do it as soon as next week.
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>
>
Re: [GitHub] wicket pull request: examples7x.wicket.apache.org/resourceaggregat...
Posted by Francois Meillet <fr...@gmail.com>.
if the CachingStrategy is FilenameWithVersionResourceCachingStrategy (default)
BasicResourceReferenceMapper # mapHandler
--> getCachingStrategy().decorateUrl(resourceUrl, cacheable);
--> FilenameWithVersionResourceCachingStrategy # decorateUrl()
--> CachingResourceVersion # getVersion()
--> resource.getCacheKey()
--> ConcatBundleResource # getCacheKey()
--> PackageResource # getCacheKey() has been modified in the commit 950df6c24196680a48646ff92b3d959f4985a238 "Improved PackageResource#getCacheKey" done on the 3/1/2016
--> PackageResource # exists()
String absolutePath = Packages.absolutePath(scope, path) is wrong
for the footer.css the absolutePath is
org/apache/wicket/examples/resourcedecoration/org/apache/wicket/examples/resourcedecoration/footer.css
--> then ConcatBundleResource # getCacheKey() return null
--> ConcatBundleResource # reportError is called
With the NoOpResourceCachingStrategy, decorateUrl does nothing, so there is no problem.
Francois
Le 5 janv. 2016 à 09:58, martin-g <gi...@git.apache.org> a écrit :
> Github user martin-g commented on the pull request:
>
> https://github.com/apache/wicket/pull/154#issuecomment-168938119
>
> It is interesting to find how this got broken.
> Do you have time to `git bisect` it ?
> I'll be able to do it as soon as next week.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
Re: [GitHub] wicket pull request: examples7x.wicket.apache.org/resourceaggregat...
Posted by Francois Meillet <fr...@gmail.com>.
I'll try today
François
Le 5 janv. 2016 à 09:58, martin-g <gi...@git.apache.org> a écrit :
> Github user martin-g commented on the pull request:
>
> https://github.com/apache/wicket/pull/154#issuecomment-168938119
>
> It is interesting to find how this got broken.
> Do you have time to `git bisect` it ?
> I'll be able to do it as soon as next week.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] wicket pull request: examples7x.wicket.apache.org/resourceaggregat...
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/154#issuecomment-168938119
It is interesting to find how this got broken.
Do you have time to `git bisect` it ?
I'll be able to do it as soon as next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---