You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2018/02/16 22:02:35 UTC

Review Request 65691: ATLAS-2454:HBase Atlas Hook: Import hbase functionality should include additional HBase attributes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65691/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Sharmadha Sainath.


Bugs: ATLAS-2454
    https://issues.apache.org/jira/browse/ATLAS-2454


Repository: atlas


Description
-------

ATLAS-2454:HBase Atlas Hook: Import hbase functionality should include additional HBase attributes


Diffs
-----

  addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java f6d511f 


Diff: https://reviews.apache.org/r/65691/diff/1/


Testing
-------

Tested in local vm.

Usage: import-hbase.sh [-n <namespace> OR --namespace <namespace>] [-t <table> OR --table <table>]


export JAVA_HOME=/usr/jdk64/jdk1.8.0_112
./import-hbase.sh -n import1
./import-hbase.sh -t import1:data


Thanks,

Ramesh Mani


Re: Review Request 65691: ATLAS-2454:HBase Atlas Hook: Import hbase functionality should include additional HBase attributes

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65691/#review197693
-----------------------------------------------------------




addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java
Lines 326 (patched)
<https://reviews.apache.org/r/65691/#comment277930>

    isCacheBloomsOnWrite() or  isCacheDataOnWrite()?


- Madhan Neethiraj


On Feb. 16, 2018, 10:02 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65691/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2018, 10:02 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2454
>     https://issues.apache.org/jira/browse/ATLAS-2454
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2454:HBase Atlas Hook: Import hbase functionality should include additional HBase attributes
> 
> 
> Diffs
> -----
> 
>   addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java f6d511f 
> 
> 
> Diff: https://reviews.apache.org/r/65691/diff/1/
> 
> 
> Testing
> -------
> 
> Tested in local vm.
> 
> Usage: import-hbase.sh [-n <namespace> OR --namespace <namespace>] [-t <table> OR --table <table>]
> 
> 
> export JAVA_HOME=/usr/jdk64/jdk1.8.0_112
> ./import-hbase.sh -n import1
> ./import-hbase.sh -t import1:data
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Re: Review Request 65691: ATLAS-2454:HBase Atlas Hook: Import hbase functionality should include additional HBase attributes

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65691/#review197718
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 17, 2018, 12:43 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65691/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2018, 12:43 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2454
>     https://issues.apache.org/jira/browse/ATLAS-2454
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2454:HBase Atlas Hook: Import hbase functionality should include additional HBase attributes
> 
> 
> Diffs
> -----
> 
>   addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java f6d511f 
> 
> 
> Diff: https://reviews.apache.org/r/65691/diff/2/
> 
> 
> Testing
> -------
> 
> Tested in local vm.
> 
> Usage: import-hbase.sh [-n <namespace> OR --namespace <namespace>] [-t <table> OR --table <table>]
> 
> 
> export JAVA_HOME=/usr/jdk64/jdk1.8.0_112
> ./import-hbase.sh -n import1
> ./import-hbase.sh -t import1:data
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Re: Review Request 65691: ATLAS-2454:HBase Atlas Hook: Import hbase functionality should include additional HBase attributes

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65691/
-----------------------------------------------------------

(Updated Feb. 17, 2018, 12:43 a.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Sharmadha Sainath.


Changes
-------

Fixed review comment


Bugs: ATLAS-2454
    https://issues.apache.org/jira/browse/ATLAS-2454


Repository: atlas


Description
-------

ATLAS-2454:HBase Atlas Hook: Import hbase functionality should include additional HBase attributes


Diffs (updated)
-----

  addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java f6d511f 


Diff: https://reviews.apache.org/r/65691/diff/2/

Changes: https://reviews.apache.org/r/65691/diff/1-2/


Testing
-------

Tested in local vm.

Usage: import-hbase.sh [-n <namespace> OR --namespace <namespace>] [-t <table> OR --table <table>]


export JAVA_HOME=/usr/jdk64/jdk1.8.0_112
./import-hbase.sh -n import1
./import-hbase.sh -t import1:data


Thanks,

Ramesh Mani