You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2016/02/02 15:06:02 UTC

Review Request 43090: Ambari Agent Creating 100, 000 Empty Status Command Files

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43090/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-14876
    https://issues.apache.org/jira/browse/AMBARI-14876


Repository: ambari


Description
-------

Agents seems to be creating 1000's of status command files when there should
only be 1. Doing an `ls` on the following directory takes 10 seconds. Here's a
snippet:

    
    
    
    [root@c6402 ~]# ll /var/lib/ambari-agent/data/
    ...
    -rw-r--r-- 1 root root        0 Jan 31 13:50 status_command_stdout.txt.99404
    -rw-r--r-- 1 root root        0 Jan 31 13:50 status_command_stdout.txt.99405
    -rw-r--r-- 1 root root        0 Jan 31 13:50 status_command_stdout.txt.99406
    -rw-r--r-- 1 root root        0 Jan 31 13:50 status_command_stdout.txt.99407
    -rw-r--r-- 1 root root        0 Jan 31 13:50 status_command_stdout.txt.99408
    -rw-r--r-- 1 root root        0 Jan 31 13:50 status_command_stdout.txt.99409
    ...
    [root@c6402 ~]# find /var/lib/ambari-agent/data -name "status_command*" | wc -l
    230582


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 6c1a161 
  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 352974f 
  ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py 4a7ed1c 

Diff: https://reviews.apache.org/r/43090/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 43090: Ambari Agent Creating 100, 000 Empty Status Command Files

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43090/#review117406
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 2, 2016, 4:06 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43090/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 4:06 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-14876
>     https://issues.apache.org/jira/browse/AMBARI-14876
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Agents seems to be creating 1000's of status command files when there should
> only be 1. Doing an `ls` on the following directory takes 10 seconds. Here's a
> snippet:
> 
>     
>     
>     
>     [root@c6402 ~]# ll /var/lib/ambari-agent/data/
>     ...
>     -rw-r--r-- 1 root root        0 Jan 31 13:50 status_command_stdout.txt.99404
>     -rw-r--r-- 1 root root        0 Jan 31 13:50 status_command_stdout.txt.99405
>     -rw-r--r-- 1 root root        0 Jan 31 13:50 status_command_stdout.txt.99406
>     -rw-r--r-- 1 root root        0 Jan 31 13:50 status_command_stdout.txt.99407
>     -rw-r--r-- 1 root root        0 Jan 31 13:50 status_command_stdout.txt.99408
>     -rw-r--r-- 1 root root        0 Jan 31 13:50 status_command_stdout.txt.99409
>     ...
>     [root@c6402 ~]# find /var/lib/ambari-agent/data -name "status_command*" | wc -l
>     230582
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 6c1a161 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 352974f 
>   ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py 4a7ed1c 
> 
> Diff: https://reviews.apache.org/r/43090/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>