You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/12 08:38:34 UTC

[GitHub] [arrow] projjal commented on a change in pull request #10068: ARROW-12422: [C++][Gandiva] Add castVARCHAR from date millis function

projjal commented on a change in pull request #10068:
URL: https://github.com/apache/arrow/pull/10068#discussion_r630842299



##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -381,6 +381,7 @@ CAST_NUMERIC_FROM_STRING(double, arrow::DoubleType, FLOAT8)
 
 GDV_FN_CAST_VARCHAR_INTEGER(int32, Int32Type)
 GDV_FN_CAST_VARCHAR_INTEGER(int64, Int64Type)
+GDV_FN_CAST_VARCHAR_INTEGER(date64, Date64Type)

Review comment:
       maybe rename the macro to GDV_FN_CAST_VARCHAR and remove GDV_FN_CAST_VARCHAR_REAL since it seems to be doing the same thing,




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org