You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/24 19:55:40 UTC
[GitHub] [tvm] wrongtest-intellif opened a new pull request, #12581: [CUDA][CodeGen] Fix cuda codegen's fp16 inf literal
wrongtest-intellif opened a new pull request, #12581:
URL: https://github.com/apache/tvm/pull/12581
Try fix https://github.com/apache/tvm/issues/12566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #12581: [CUDA][CodeGen] Fix cuda codegen's fp16 inf literal
Posted by GitBox <gi...@apache.org>.
vinx13 commented on PR #12581:
URL: https://github.com/apache/tvm/pull/12581#issuecomment-1226312527
cc @shingjan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] shingjan commented on a diff in pull request #12581: [CUDA][CodeGen] Fix cuda codegen's fp16 inf literal
Posted by GitBox <gi...@apache.org>.
shingjan commented on code in PR #12581:
URL: https://github.com/apache/tvm/pull/12581#discussion_r954289942
##########
src/target/source/codegen_cuda.cc:
##########
@@ -1197,8 +1197,10 @@ inline void PrintConst(const FloatImmNode* op, std::ostream& os, CodeGenCUDA* p)
break;
}
case 16: {
- os << "__float2half_rn";
- os << '(' << std::scientific << op->value << 'f' << ')';
+ os << "__float2half_rn" << '(';
Review Comment:
Would that be possible that some tests are added? We can probably re-use my repro [here](https://gist.github.com/shingjan/9ee06597a13f9be324828afb6c4560b8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 merged pull request #12581: [CUDA][CodeGen] Fix cuda codegen's fp16 inf literal
Posted by GitBox <gi...@apache.org>.
vinx13 merged PR #12581:
URL: https://github.com/apache/tvm/pull/12581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] shingjan commented on a diff in pull request #12581: [CUDA][CodeGen] Fix cuda codegen's fp16 inf literal
Posted by GitBox <gi...@apache.org>.
shingjan commented on code in PR #12581:
URL: https://github.com/apache/tvm/pull/12581#discussion_r954289942
##########
src/target/source/codegen_cuda.cc:
##########
@@ -1197,8 +1197,10 @@ inline void PrintConst(const FloatImmNode* op, std::ostream& os, CodeGenCUDA* p)
break;
}
case 16: {
- os << "__float2half_rn";
- os << '(' << std::scientific << op->value << 'f' << ')';
+ os << "__float2half_rn" << '(';
Review Comment:
Would that be possible that we add some test? We can probably re-use my repro [here](https://gist.github.com/shingjan/9ee06597a13f9be324828afb6c4560b8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest-intellif commented on a diff in pull request #12581: [CUDA][CodeGen] Fix cuda codegen's fp16 inf literal
Posted by GitBox <gi...@apache.org>.
wrongtest-intellif commented on code in PR #12581:
URL: https://github.com/apache/tvm/pull/12581#discussion_r954791246
##########
src/target/source/codegen_cuda.cc:
##########
@@ -1197,8 +1197,10 @@ inline void PrintConst(const FloatImmNode* op, std::ostream& os, CodeGenCUDA* p)
break;
}
case 16: {
- os << "__float2half_rn";
- os << '(' << std::scientific << op->value << 'f' << ')';
+ os << "__float2half_rn" << '(';
Review Comment:
the case is added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] shingjan commented on a diff in pull request #12581: [CUDA][CodeGen] Fix cuda codegen's fp16 inf literal
Posted by GitBox <gi...@apache.org>.
shingjan commented on code in PR #12581:
URL: https://github.com/apache/tvm/pull/12581#discussion_r954289942
##########
src/target/source/codegen_cuda.cc:
##########
@@ -1197,8 +1197,10 @@ inline void PrintConst(const FloatImmNode* op, std::ostream& os, CodeGenCUDA* p)
break;
}
case 16: {
- os << "__float2half_rn";
- os << '(' << std::scientific << op->value << 'f' << ')';
+ os << "__float2half_rn" << '(';
Review Comment:
Would that be possible that we can add some test? We can probably re-use my repro [here](https://gist.github.com/shingjan/9ee06597a13f9be324828afb6c4560b8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org