[jira] Resolved: (HTTPCLIENT-946) Documentation Bug in SSL Guide

["Oleg Kalnichevski (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-946.
------------------------------------------

    Resolution: Won't Fix

Andreas,
I do not think the documentation is wrong. It just the API is not good. At any rate there is no point fixing non-critical bugs in the 3.x branch, as there are no releases planned for HttpClient 3.x

Oleg

> Documentation Bug in SSL Guide
> ------------------------------
>
>                 Key: HTTPCLIENT-946
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-946
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 3.1 Final
>            Reporter: Andreas Sahlbach
>
> In the SSL Guide for commons-httpclient-3.x you can find the following section:
> -----
> {noformat} 
> Finally, you can register your custom protocol as the default handler for a specific protocol designator (eg: https) by calling the Protocol.registerProtocol method. You can specify your own protocol designator (such as 'myhttps') if you need to use your custom protocol as well as the default SSL protocol implementation.
> {noformat}
> {code:java}
> Protocol.registerProtocol("myhttps", 
> new Protocol("https", new MySSLSocketFactory(), 9443));
> {code}
> -----
> IMHO the first Parameter in the Protocol constructor must be "myhttps", too. At least here only in this case the new Protocol is found and the MySSLSocketFactory is actually used. The original code only seems to work, because the register call doesn't fail, but the normal SSL Protocol object is actually used.
> PS: hope this confluence format stuff actually works. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org