You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/01/03 22:15:23 UTC
[kudu-CR] thirdparty: pass EXTRA MAKEFLAGS in build-thirdparty.sh
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5595
to review the following change.
Change subject: thirdparty: pass EXTRA_MAKEFLAGS in build-thirdparty.sh
......................................................................
thirdparty: pass EXTRA_MAKEFLAGS in build-thirdparty.sh
And allow PARALLEL to be overridden. Taken together, this makes it easier to
limit the parallelism of the thirdparty build.
The Kudu build itself needs no such mechanism as its make invocations aren't
hidden behind a shell script.
Change-Id: I69cda8e9a4a7d2ff0db1140f71ab247e14627035
---
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
2 files changed, 22 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/5595/1
--
To view, visit http://gerrit.cloudera.org:8080/5595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69cda8e9a4a7d2ff0db1140f71ab247e14627035
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] thirdparty: pass EXTRA MAKEFLAGS in build-thirdparty.sh
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: thirdparty: pass EXTRA_MAKEFLAGS in build-thirdparty.sh
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69cda8e9a4a7d2ff0db1140f71ab247e14627035
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] thirdparty: pass EXTRA MAKEFLAGS in build-thirdparty.sh
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: thirdparty: pass EXTRA_MAKEFLAGS in build-thirdparty.sh
......................................................................
thirdparty: pass EXTRA_MAKEFLAGS in build-thirdparty.sh
And allow PARALLEL to be overridden. Taken together, this makes it easier to
limit the parallelism of the thirdparty build.
The Kudu build itself needs no such mechanism as its make invocations aren't
hidden behind a shell script.
Change-Id: I69cda8e9a4a7d2ff0db1140f71ab247e14627035
Reviewed-on: http://gerrit.cloudera.org:8080/5595
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
2 files changed, 22 insertions(+), 21 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69cda8e9a4a7d2ff0db1140f71ab247e14627035
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>