You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sgilmore10 (via GitHub)" <gi...@apache.org> on 2025/07/07 18:57:37 UTC
[PR] GH-35644: [MATLAB] Add tests verifying `arrow.array.Array.fromMATLAB()` throws an exception if given an array with the wrong type. [arrow]
sgilmore10 opened a new pull request, #47020:
URL: https://github.com/apache/arrow/pull/47020
### Rationale for this change
This PR closes a test coverage gap for `arrow.array.<Type>Array.fromMATLAB(data)`.
### What changes are included in this PR?
1. Added `hNumericArray/ErrorIfInvalidType`, which verifies `arrow.array.<Type>Array.fromMATLAB(data)` throws an exception if `data` has an unexpected type.
2. Added tBooleanArray/ErrorIfNotLogical`, which verifies `arrow.array.BooleanArray.fromMATLAB(data)` throws an exception if `data` is not a `logical` array.
3. Added tTimestampArray/ErrorIfNotLogical`, which verifies `arrow.array.TimestampArray.fromMATLAB(data)` throws an exception if `data` is not a `datetime` array.
### Are these changes tested?
This is a test-only PR.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35644: [MATLAB] Add tests verifying `arrow.array.Array.fromMATLAB()` throws an exception if given an array with the wrong type. [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47020:
URL: https://github.com/apache/arrow/pull/47020#issuecomment-3047112295
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 73472a958d50ffb181e9daa0ac891d7e2a76a637.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/45521554900) has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35644: [MATLAB] Add tests verifying `arrow.array.Array.fromMATLAB()` throws an exception if given an array with the wrong type. [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 merged PR #47020:
URL: https://github.com/apache/arrow/pull/47020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org