[jira] [Comment Edited] (CASSANDRA-4959) CQLSH insert help has typo

["Andy Zhao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-4959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839798#comment-13839798 ] 

Andy Zhao edited comment on CASSANDRA-4959 at 12/5/13 4:45 AM:
---------------------------------------------------------------

There are two more typo in this help text:
* there is an extra "]" in *\[USING TIMESTAMP <timestamp>\]* which should be removed. 
* the first "]" in *\[AND TTL <timeToLive\]\]* should be changed to ">"

For now we could just fix these typos as below:
{quote}
\[USING TIMESTAMP <timestamp> | TTL <timeToLive> \[AND TTL <timeToLive> | TIMESTAMP <timestamp> \] \];
{quote}
It seems verbose but at least it won't mislead people into thinking "AND TTL <timeToLive>" can be used without "USING TIMESTAMP". Same fix needs to be applied to other help topic too, such as "UPDATE" command. 

I think having "AND" keyword in the grammar is a mistake because parser doesn't need it and it seems verbose, but this is out of scope.


was (Author: andy888):
There are two more typo in this help text:
* there is an extra "]" in *\[USING TIMESTAMP <timestamp>\]* which should be removed. 
* the first "]" in *\[AND TTL <timeToLive\]\]* should be changed to ">"

For now we could just fix the original issue as below:
{quote}
\[USING TIMESTAMP <timestamp> | TTL <timeToLive> \[AND TTL <timeToLive> | TIMESTAMP <timestamp> \] \];
{quote}
It seems verbose but at least it won't mislead people into thinking "AND TTL <timeToLive>" can be used without "USING TIMESTAMP". Same fix needs to be applied to other help topic too, such as "UPDATE" command. 

I think having "AND" keyword in the grammar is a mistake because parser doesn't need it and it seems verbose, but this is out of scope.

> CQLSH insert help has typo
> --------------------------
>
>                 Key: CASSANDRA-4959
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4959
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Documentation & website
>    Affects Versions: 1.2.0 beta 2
>            Reporter: Edward Capriolo
>            Priority: Trivial
>
> [cqlsh 2.3.0 | Cassandra 1.2.0-beta2-SNAPSHOT | CQL spec 3.0.0 | Thrift protocol 19.35.0]
> Use HELP for help.
> cqlsh> help INSERT
>         INSERT INTO [<keyspace>.]<tablename>
>                     ( <colname1>, <colname2> [, <colname3> [, ...]] )
>                VALUES ( <colval1>, <colval2> [, <colval3> [, ...]] )
>                [USING TIMESTAMP <timestamp>]
>                  [AND TTL <timeToLive]];
> Should be. 
> {quote}
> [AND TTL <timeToLive>]];
> {quote}
> Also it was not clear to me initially that you could just do:
> {quote}
> USING TTL <timeToLive>
> {quote}
> But maybe that is just me.



--
This message was sent by Atlassian JIRA
(v6.1#6144)