You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2019/02/06 22:43:46 UTC
[GitHub] [geode] kirklund opened pull request #3168: GEODE-6033: Make
SharedErrorCollector support create and bounce VM
[ Full content available at: https://github.com/apache/geode/pull/3168 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on issue #3168: GEODE-6033:
Support dynamic VMs in SharedErrorCollector
Posted by "kirklund (GitHub)" <gi...@apache.org>.
DistributedTest failures are:
- DistributedAckRegionOffHeapDUnitTest.testNBRegionDestructionDuringGetInitialImage
- DistributedAckRegionOffHeapDUnitTest.testNBRegionDestructionDuringGetInitialImage
Which appear to be caused by
```
commit bfc0449e81b7ac5429f7473b216762c22c10f95b
Author: Xiaojian Zhou <ge...@users.noreply.github.com>
Date: Wed Feb 6 17:14:34 2019 -0800
GEODE-6277: use await() instead of hard-coded sleep(3000) in the test (#3086)
```
The hang in build is caused by concourse scripting:
```
put failed: failed to set status: Post https://api.github.com/repos/apache/geode/statuses/643d788a4ca79aac28427ecbcf43532ace690d43: net/http: TLS handshake timeout
```
[ Full content available at: https://github.com/apache/geode/pull/3168 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] demery-pivotal commented on pull request #3168:
GEODE-6033: Support dynamic VMs in SharedErrorCollector
Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.
Something like `whenVMDoesNotAddError_resultIsSuccessful()`. Similar for other tests where no failures are added.
[ Full content available at: https://github.com/apache/geode/pull/3168 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund closed pull request #3168: GEODE-6033:
Support dynamic VMs in SharedErrorCollector
Posted by "kirklund (GitHub)" <gi...@apache.org>.
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/3168 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] demery-pivotal commented on pull request #3168:
GEODE-6033: Support dynamic VMs in SharedErrorCollector
Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.
Maybe also assert that `result.getFailures()` is empty.
[ Full content available at: https://github.com/apache/geode/pull/3168 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on issue #3168: GEODE-6033:
Support dynamic VMs in SharedErrorCollector
Posted by "kirklund (GitHub)" <gi...@apache.org>.
DistributedTest failures are:
- DistributedAckRegionDUnitTest.testNBRegionDestructionDuringGetInitialImage
- DistributedAckRegionOffHeapDUnitTest.testNBRegionDestructionDuringGetInitialImage
Which appear to be caused by
```
commit bfc0449e81b7ac5429f7473b216762c22c10f95b
Author: Xiaojian Zhou <ge...@users.noreply.github.com>
Date: Wed Feb 6 17:14:34 2019 -0800
GEODE-6277: use await() instead of hard-coded sleep(3000) in the test (#3086)
```
The hang in build is caused by concourse scripting:
```
put failed: failed to set status: Post https://api.github.com/repos/apache/geode/statuses/643d788a4ca79aac28427ecbcf43532ace690d43: net/http: TLS handshake timeout
```
[ Full content available at: https://github.com/apache/geode/pull/3168 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] demery-pivotal commented on pull request #3168:
GEODE-6033: Support dynamic VMs in SharedErrorCollector
Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.
Consider `whenNewDunitVMAddsError_resultIncludesError()` or similar. Similar for the other tests where VMs add errors.
[ Full content available at: https://github.com/apache/geode/pull/3168 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on issue #3168: GEODE-6033:
Support dynamic VMs in SharedErrorCollector
Posted by "kirklund (GitHub)" <gi...@apache.org>.
DistributedTest failures are:
- DistributedAckRegionOffHeapDUnitTest.testNBRegionDestructionDuringGetInitialImage
- DistributedAckRegionOffHeapDUnitTest.testNBRegionDestructionDuringGetInitialImage
Which appears to be caused by
```
commit bfc0449e81b7ac5429f7473b216762c22c10f95b
Author: Xiaojian Zhou <ge...@users.noreply.github.com>
Date: Wed Feb 6 17:14:34 2019 -0800
GEODE-6277: use await() instead of hard-coded sleep(3000) in the test (#3086)
```
The hang in build is caused by concourse scripting:
```
put failed: failed to set status: Post https://api.github.com/repos/apache/geode/statuses/643d788a4ca79aac28427ecbcf43532ace690d43: net/http: TLS handshake timeout
```
[ Full content available at: https://github.com/apache/geode/pull/3168 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on issue #3168: GEODE-6033:
Support dynamic VMs in SharedErrorCollector
Posted by "kirklund (GitHub)" <gi...@apache.org>.
@demery-pivotal @moleske please review latest changes. I went ahead and changed all of the test method names to follow the new convention. I also changed the test to use the geode-junit TestRunner which is used by other geode rule tests.
[ Full content available at: https://github.com/apache/geode/pull/3168 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org