You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by saksham srivastava <sa...@citrix.com> on 2012/10/01 17:40:37 UTC

Review Request: CLOUDSTACK-91 : no error message when we upload volume whose size is greater than storage.max.volume.upload.size value

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7373/
-----------------------------------------------------------

Review request for cloudstack and Pranav Saxena.


Description
-------

Added a new field "status" in UI for listVolumes that displays the upload status of the volume. 
In case of size being greater than storage.max.volume.upload.size, error string is displayed.


This addresses bug CLOUDSTACK-91.


Diffs
-----

  ui/scripts/storage.js 418fe36 

Diff: https://reviews.apache.org/r/7373/diff/


Testing
-------

Verified locally.


Thanks,

saksham srivastava


Re: Review Request: CLOUDSTACK-91 : no error message when we upload volume whose size is greater than storage.max.volume.upload.size value

Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7373/#review12063
-----------------------------------------------------------

Ship it!


Ship It!

- Pranav Saxena


On Oct. 1, 2012, 3:40 p.m., saksham srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7373/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2012, 3:40 p.m.)
> 
> 
> Review request for cloudstack and Pranav Saxena.
> 
> 
> Description
> -------
> 
> Added a new field "status" in UI for listVolumes that displays the upload status of the volume. 
> In case of size being greater than storage.max.volume.upload.size, error string is displayed.
> 
> 
> This addresses bug CLOUDSTACK-91.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/storage.js 418fe36 
> 
> Diff: https://reviews.apache.org/r/7373/diff/
> 
> 
> Testing
> -------
> 
> Verified locally.
> 
> 
> Thanks,
> 
> saksham srivastava
> 
>


Re: Review Request: CLOUDSTACK-91 : no error message when we upload volume whose size is greater than storage.max.volume.upload.size value

Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7373/#review12064
-----------------------------------------------------------


Changes have been pushed to asf/master after verifying your patch . Please mark the ticket as "submitted" .

- Pranav Saxena


On Oct. 1, 2012, 3:40 p.m., saksham srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7373/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2012, 3:40 p.m.)
> 
> 
> Review request for cloudstack and Pranav Saxena.
> 
> 
> Description
> -------
> 
> Added a new field "status" in UI for listVolumes that displays the upload status of the volume. 
> In case of size being greater than storage.max.volume.upload.size, error string is displayed.
> 
> 
> This addresses bug CLOUDSTACK-91.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/storage.js 418fe36 
> 
> Diff: https://reviews.apache.org/r/7373/diff/
> 
> 
> Testing
> -------
> 
> Verified locally.
> 
> 
> Thanks,
> 
> saksham srivastava
> 
>