You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Matt Benson (Created) (JIRA)" <ji...@apache.org> on 2012/01/21 04:06:44 UTC
[jira] [Created] (FUNCTOR-12) improve test coverage
improve test coverage
---------------------
Key: FUNCTOR-12
URL: https://issues.apache.org/jira/browse/FUNCTOR-12
Project: Commons Functor
Issue Type: Improvement
Reporter: Emmanuel Bourg
Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by Simone Tripodi <si...@apache.org>.
Hi Shiva,
you maybe subscribed to one or more commons MLs, so follow the
"Unsubscribe" links[1] on commons Mailing List pages.
Or, you maybe starred that issue on JIRA, so all you have to do is
"unstar" it :)
HTH,
-Simo
[1] http://commons.apache.org/mail-lists.html
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Thu, Aug 2, 2012 at 8:02 AM, Shiva Krishnan <sh...@gmail.com> wrote:
> Can someone please help me know how to unsubscribe from this DL ?
> Appreciate in advance.
>
> thanks
> Shiva
>
>
> On 23 July 2012 16:31, Bruno P. Kinoshita (JIRA) <ji...@apache.org> wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420715#comment-13420715]
>>
>> Bruno P. Kinoshita commented on FUNCTOR-12:
>> -------------------------------------------
>>
>> Test for functor core algorithms in [r1354803|
>> http://svn.apache.org/viewvc?view=revision&revision=1354803]
>>
>> Author: kinow
>> Date: Thu Jun 28 02:59:23 2012
>> New Revision: 1354803
>>
>> URL: http://svn.apache.org/viewvc?rev=1354803&view=rev
>> Log:
>> Tests for functor core algorithms. Work related to FUNCTOR-12.
>>
>> A few algorithm classes weren't using BaseFunctorTest. It was changed in
>> this
>> commit. Some further work was needed to make test-objects serializable.
>> And an
>> extra test was included in BaseFunctorTest, to compare (using equals) a
>> functor
>> with a non-functor object.
>>
>> Modified:
>>
>> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/BaseFunctorTest.java
>>
>> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestDoUntil.java
>>
>> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestDoWhile.java
>>
>> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestFoldLeft.java
>>
>> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestFoldRight.java
>>
>> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestInPlaceTransform.java
>>
>> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestIndexOfInGenerator.java
>>
>> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestRecursiveEvaluation.java
>>
>> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestRemoveMatching.java
>>
>> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestRetainMatching.java
>>
>> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestUntilDo.java
>>
>> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestWhileDo.java
>>
>> > improve test coverage
>> > ---------------------
>> >
>> > Key: FUNCTOR-12
>> > URL: https://issues.apache.org/jira/browse/FUNCTOR-12
>> > Project: Commons Functor
>> > Issue Type: Improvement
>> > Reporter: Emmanuel Bourg
>> > Assignee: Bruno P. Kinoshita
>> >
>> > Specifically the composite package contains untested classes, per
>> http://markmail.org/message/ythw55yad5lrvqrj
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
Re: [jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by Shiva Krishnan <sh...@gmail.com>.
Can someone please help me know how to unsubscribe from this DL ?
Appreciate in advance.
thanks
Shiva
On 23 July 2012 16:31, Bruno P. Kinoshita (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420715#comment-13420715]
>
> Bruno P. Kinoshita commented on FUNCTOR-12:
> -------------------------------------------
>
> Test for functor core algorithms in [r1354803|
> http://svn.apache.org/viewvc?view=revision&revision=1354803]
>
> Author: kinow
> Date: Thu Jun 28 02:59:23 2012
> New Revision: 1354803
>
> URL: http://svn.apache.org/viewvc?rev=1354803&view=rev
> Log:
> Tests for functor core algorithms. Work related to FUNCTOR-12.
>
> A few algorithm classes weren't using BaseFunctorTest. It was changed in
> this
> commit. Some further work was needed to make test-objects serializable.
> And an
> extra test was included in BaseFunctorTest, to compare (using equals) a
> functor
> with a non-functor object.
>
> Modified:
>
> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/BaseFunctorTest.java
>
> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestDoUntil.java
>
> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestDoWhile.java
>
> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestFoldLeft.java
>
> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestFoldRight.java
>
> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestInPlaceTransform.java
>
> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestIndexOfInGenerator.java
>
> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestRecursiveEvaluation.java
>
> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestRemoveMatching.java
>
> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestRetainMatching.java
>
> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestUntilDo.java
>
> commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestWhileDo.java
>
> > improve test coverage
> > ---------------------
> >
> > Key: FUNCTOR-12
> > URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> > Project: Commons Functor
> > Issue Type: Improvement
> > Reporter: Emmanuel Bourg
> > Assignee: Bruno P. Kinoshita
> >
> > Specifically the composite package contains untested classes, per
> http://markmail.org/message/ythw55yad5lrvqrj
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421844#comment-13421844 ]
Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------
Author: kinow
Date: Tue Jul 24 22:14:33 2012
New Revision: 1365325
URL: http://svn.apache.org/viewvc?rev=1365325&view=rev
Log:
[FUNCTOR-12] Added test for AbstractListBackedAggregator no args constructor (created for JavaBean compatibility). Replaced the not-null-verification by Validate.notNull().
Modified:
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/aggregator/AbstractListBackedAggregator.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/aggregator/AbstractNoStoreAggregatorTest.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421845#comment-13421845 ]
Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------
Author: kinow
Date: Tue Jul 24 22:15:31 2012
New Revision: 1365326
URL: http://svn.apache.org/viewvc?rev=1365326&view=rev
Log:
Added tests to LeftIdentity and RightIdentity no args constructors (created for compatibility with tools using JavaBeans).
Modified:
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/TestLeftIdentity.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/TestRightIdentity.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421909#comment-13421909 ]
Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------
Author: kinow
Date: Wed Jul 25 00:59:23 2012
New Revision: 1365377
URL: http://svn.apache.org/viewvc?rev=1365377&view=rev
Log:
[FUNCTOR-12] Added more tests for the adapter classes. Also removed unreachable code, as it could not be tested and was immutable and created/validated during construction.
Some objects were immutable but could be null. In cases like this, no code was added, and the null validation was left in place, i.e. no if's were removed. See FullyBoundFunction for an example where the functor was validated, but the other arguments could be null, and in equals() and hashcode() the validation wasn't removed.
Modified:
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/BinaryFunctionBinaryPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/BinaryFunctionBinaryProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/BinaryPredicateBinaryFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/BinaryProcedureBinaryFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/BoundPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/BoundProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/FullyBoundFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/FullyBoundPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/FullyBoundProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/FunctionPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/FunctionProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/FunctionUnaryFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/IgnoreLeftFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/IgnoreLeftPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/IgnoreLeftProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/IgnoreRightFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/IgnoreRightPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/IgnoreRightProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/LeftBoundFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/LeftBoundPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/LeftBoundProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/PredicateFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/PredicateUnaryPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/ProcedureFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/ProcedureUnaryProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/RightBoundFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/RightBoundPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/RightBoundProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/UnaryFunctionUnaryPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/UnaryFunctionUnaryProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/UnaryPredicateUnaryFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/UnaryProcedureUnaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBinaryFunctionBinaryPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBinaryFunctionBinaryProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBinaryPredicateBinaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBinaryProcedureBinaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBinaryProcedureUnaryProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBoundFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBoundPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBoundProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestFullyBoundFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestFullyBoundPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestFullyBoundProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestFunctionPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestFunctionProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestFunctionUnaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestIgnoreLeftFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestIgnoreLeftPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestIgnoreLeftProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestIgnoreRightFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestIgnoreRightPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestIgnoreRightProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestLeftBoundFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestLeftBoundPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestLeftBoundProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestPredicateFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestPredicateUnaryPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestProcedureFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestProcedureUnaryProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestRightBoundFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestRightBoundPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestRightBoundProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestUnaryFunctionUnaryPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestUnaryFunctionUnaryProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestUnaryPredicateUnaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestUnaryProcedureUnaryFunction.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420843#comment-13420843 ]
Bruno P. Kinoshita edited comment on FUNCTOR-12 at 7/23/12 6:23 PM:
--------------------------------------------------------------------
Tests for functor core collections in [r1364742|http://svn.apache.org/viewvc?rev=1364742&view=rev]. Some methods that were using try/catch blocks with fail were updated to use @Test(expected=SomeException.class).
Author: kinow
Date: Mon Jul 23 18:20:48 2012
New Revision: 1364742
URL: http://svn.apache.org/viewvc?rev=1364742&view=rev
Log:
[FUNCTOR-12] Tests for functor core collections.
Modified:
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/collection/TestFilteredIterable.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/collection/TestFilteredIterator.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/collection/TestTransformedIterator.java
was (Author: kinow):
Tests for functor core collections in [r1364704|http://svn.apache.org/viewvc?rev=1364742&view=rev]. Some methods that were using try/catch blocks with fail were updated to use @Test(expected=SomeException.class).
Author: kinow
Date: Mon Jul 23 18:20:48 2012
New Revision: 1364742
URL: http://svn.apache.org/viewvc?rev=1364742&view=rev
Log:
[FUNCTOR-12] Tests for functor core collections.
Modified:
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/collection/TestFilteredIterable.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/collection/TestFilteredIterator.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/collection/TestTransformedIterator.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420715#comment-13420715 ]
Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------
Test for functor core algorithms in [r1354803|http://svn.apache.org/viewvc?view=revision&revision=1354803]
Author: kinow
Date: Thu Jun 28 02:59:23 2012
New Revision: 1354803
URL: http://svn.apache.org/viewvc?rev=1354803&view=rev
Log:
Tests for functor core algorithms. Work related to FUNCTOR-12.
A few algorithm classes weren't using BaseFunctorTest. It was changed in this
commit. Some further work was needed to make test-objects serializable. And an
extra test was included in BaseFunctorTest, to compare (using equals) a functor
with a non-functor object.
Modified:
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/BaseFunctorTest.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestDoUntil.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestDoWhile.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestFoldLeft.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestFoldRight.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestInPlaceTransform.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestIndexOfInGenerator.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestRecursiveEvaluation.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestRemoveMatching.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestRetainMatching.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestUntilDo.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestWhileDo.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421850#comment-13421850 ]
Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------
Author: kinow
Date: Tue Jul 24 22:40:04 2012
New Revision: 1365330
URL: http://svn.apache.org/viewvc?rev=1365330&view=rev
Log:
[FUNCTOR-12] Added more tests for the generator classes (and util classes). Also removed unreachable code, as it could not be tested and was immutable and created/validated during construction. Tests that were using a try/catch + fail() approach were updated to use @Test(expected=SomeClass.class). Test classes missing $revision and $data svn tags were updated too.
Modified:
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/generator/FilteredGenerator.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/generator/GenerateUntil.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/generator/GenerateWhile.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/generator/TransformedGenerator.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/generator/UntilGenerate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/generator/WhileGenerate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/generator/TestFilteredGenerator.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/generator/TestGenerateUntil.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/generator/TestGenerateWhile.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/generator/TestTransformedGenerator.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/generator/TestUntilGenerate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/generator/TestWhileGenerate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/generator/util/TestEachElement.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/generator/util/TestIntegerRange.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/generator/util/TestLongRange.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421847#comment-13421847 ]
Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------
Author: kinow
Date: Tue Jul 24 22:19:23 2012
New Revision: 1365328
URL: http://svn.apache.org/viewvc?rev=1365328&view=rev
Log:
[FUNCTOR-12] Added more tests to core comparator classes. Also removed unreachable code, as it could not be tested and was immutable and created/validated during construction.
Modified:
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsEquivalent.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsGreaterThan.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsGreaterThanOrEqual.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsLessThan.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsLessThanOrEqual.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsNotEquivalent.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestComparatorFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsEquivalent.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by "Matt Benson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190289#comment-13190289 ]
Matt Benson commented on FUNCTOR-12:
------------------------------------
Also most {{equals}}/{{hashCode}} methods are not tested.
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420843#comment-13420843 ]
Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------
Tests for functor core collections in [r1364704|http://svn.apache.org/viewvc?rev=1364742&view=rev]. Some methods that were using try/catch blocks with fail were updated to use @Test(expected=SomeException.class).
Author: kinow
Date: Mon Jul 23 18:20:48 2012
New Revision: 1364742
URL: http://svn.apache.org/viewvc?rev=1364742&view=rev
Log:
[FUNCTOR-12] Tests for functor core collections.
Modified:
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/collection/TestFilteredIterable.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/collection/TestFilteredIterator.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/collection/TestTransformedIterator.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno P. Kinoshita resolved FUNCTOR-12.
---------------------------------------
Resolution: Fixed
Fixed in [r1354803|http://svn.apache.org/viewvc?rev=1354803&view=rev], [r1364704|http://svn.apache.org/viewvc?rev=1364704&view=rev], [r1364742|http://svn.apache.org/viewvc?rev=1364742&view=rev], [r1364767|http://svn.apache.org/viewvc?rev=1364767&view=rev], [r1365325|http://svn.apache.org/viewvc?rev=1365325&view=rev], [r1365326|http://svn.apache.org/viewvc?rev=1365326&view=rev], [r1365327|http://svn.apache.org/viewvc?rev=1365327&view=rev], [r1365328|http://svn.apache.org/viewvc?rev=1365328&view=rev], [r1365329|http://svn.apache.org/viewvc?rev=1365329&view=rev], [r1365330|http://svn.apache.org/viewvc?rev=1365330&view=rev], [r1365377|http://svn.apache.org/viewvc?rev=1365377&view=rev].
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421846#comment-13421846 ]
Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------
Author: kinow
Date: Tue Jul 24 22:16:56 2012
New Revision: 1365327
URL: http://svn.apache.org/viewvc?rev=1365327&view=rev
Log:
[FUNCTOR-12] Added tests for FindWithinGenerator that cover untested branches. Replaced a try/catch + fail() by @Test(expected=SomeClass.class).
Modified:
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/algorithm/TestFindWithinGenerator.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421849#comment-13421849 ]
Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------
Author: kinow
Date: Tue Jul 24 22:34:23 2012
New Revision: 1365329
URL: http://svn.apache.org/viewvc?rev=1365329&view=rev
Log:
[FUNCTOR-12] Added more tests to core composite classes. Also removed unreachable code, as it could not be tested and was immutable and created/validated during construction. Tests that were using a try/catch + fail() approach were updated to use @Test(expected=SomeClass.class). There was one class with tests in JUnit 3 format that weren't being executed by JUnit 4, it was corrected by adding @Test to its methods. And new classes were added for classes not covered (the license header was copied from other classes).
Added:
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransformedBinaryFunction.java (with props)
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransformedBinaryProcedure.java (with props)
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransformedFunction.java (with props)
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransformedProcedure.java (with props)
Modified:
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/AbstractLoopProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BaseBinaryPredicateList.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BasePredicateList.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BaseUnaryPredicateList.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinaryNot.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/Composite.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/CompositeUnaryFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalBinaryFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalBinaryPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalBinaryProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalUnaryFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalUnaryPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalUnaryProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/Not.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/Sequence.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedBinaryFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedBinaryProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransposedFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransposedPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransposedProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/UnaryNot.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestAbstractLoopProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestAnd.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestBinaryAnd.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestBinaryCompositeBinaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestBinaryNot.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestBinaryOr.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestBinarySequence.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestComposite.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestCompositeUnaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestCompositeUnaryPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestCompositeUnaryProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditional.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalBinaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalBinaryPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalBinaryProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalUnaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalUnaryPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalUnaryProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestNot.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestOr.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestSequence.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransposedFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransposedPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransposedProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestUnaryAnd.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestUnaryCompositeBinaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestUnaryCompositeBinaryPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestUnaryNot.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestUnaryOr.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420907#comment-13420907 ]
Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------
Author: kinow
Date: Mon Jul 23 19:36:08 2012
New Revision: 1364767
URL: http://svn.apache.org/viewvc?rev=1364767&view=rev
Log:
[FUNCTOR-12] Tests for functor core. RightIdentity wasn't using the prodedure() method, but duplicating the code for this method in two places. This commit fixes it too. LeftIdentity had the right code, so no change was necessary.
Tests using try/catch + fail() were updated to use @Test(expected=SomeException.class).
Modified:
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/RightIdentity.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/TestConstant.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/TestIsEqual.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/TestIsNotEqual.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/TestIsNotSame.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/TestIsSame.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/TestLeftIdentity.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/TestLimit.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/TestNoOp.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/TestOffset.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/TestRightIdentity.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FUNCTOR-12) improve test coverage
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420770#comment-13420770 ]
Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------
Tests for functor core comparators in [r1364704|http://svn.apache.org/viewvc?rev=1364704&view=rev]. Covering branches with null objects in the tests.
Author: kinow
Date: Mon Jul 23 16:40:49 2012
New Revision: 1364704
URL: http://svn.apache.org/viewvc?rev=1364704&view=rev
Log:
[FUNCTOR-12] Tests for functor core comparators.
Modified:
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsEquivalent.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsGreaterThan.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsGreaterThanOrEqual.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsLessThan.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsLessThanOrEqual.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsNotEquivalent.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestMax.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestMin.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira