You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "junichi11 (via GitHub)" <gi...@apache.org> on 2023/07/20 14:20:59 UTC

[GitHub] [netbeans] junichi11 opened a new pull request, #6237: Avoid getting all types with an empty type name #6039

junichi11 opened a new pull request, #6237:
URL: https://github.com/apache/netbeans/pull/6237

   - https://github.com/apache/netbeans/issues/6039
   - Remove `<>` and `{}` from type name
   - Ignore an empty type name to avoid getting all types
   - Add unit tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net merged pull request #6237: Avoid getting all types with an empty type name #6039

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net merged PR #6237:
URL: https://github.com/apache/netbeans/pull/6237


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #6237: Avoid getting all types with an empty type name #6039

Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on PR #6237:
URL: https://github.com/apache/netbeans/pull/6237#issuecomment-1644482284

   @junichi11 Thank you!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on a diff in pull request #6237: Avoid getting all types with an empty type name #6039

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on code in PR #6237:
URL: https://github.com/apache/netbeans/pull/6237#discussion_r1269548429


##########
php/php.editor/src/org/netbeans/modules/php/editor/actions/ImportDataCreator.java:
##########
@@ -87,6 +88,10 @@ public ImportData create() {
     }
 
     private void processFQElementName(final String fqElementName) {
+        // GH-6039: avoid getting all types
+        if (!StringUtils.hasText(fqElementName)) {
+            return;
+        }
         // GH-6075
         String fqeName = CodeUtils.removeNullableTypePrefix(fqElementName);
         Collection<FullyQualifiedElement> possibleFQElements = fetchPossibleFQElements(fqeName);

Review Comment:
   Before: got all types with an empty type name here. So, the following method was called many times.
   
   https://github.com/apache/netbeans/blob/9e68d3d9630f9403fc14c3a389c803643d92521f/php/php.editor/src/org/netbeans/modules/php/editor/actions/FixDuplicateImportStmts.java#L248-L259



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #6237: Avoid getting all types with an empty type name #6039

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6237:
URL: https://github.com/apache/netbeans/pull/6237#issuecomment-1644657748

   @tmysik Thank you for your review! I'll wait for being merged by the release team :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists