You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "duongkame (via GitHub)" <gi...@apache.org> on 2024/01/16 23:49:54 UTC
[PR] RATIS-1934. Support Zero-Copy in GrpcServerProtocolService [ratis]
duongkame opened a new pull request, #1014:
URL: https://github.com/apache/ratis/pull/1014
## What changes were proposed in this pull request?
Support Zero-Copy in GrpcServerProtocolService.appendEntries
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1934
## How was this patch tested?
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1934. Support Zero-Copy in GrpcServerProtocolService [ratis]
Posted by "duongkame (via GitHub)" <gi...@apache.org>.
duongkame commented on PR #1014:
URL: https://github.com/apache/ratis/pull/1014#issuecomment-1899168314
@szetszwo can you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1934. Support Zero-Copy in GrpcServerProtocolService [ratis]
Posted by "duongkame (via GitHub)" <gi...@apache.org>.
duongkame commented on PR #1014:
URL: https://github.com/apache/ratis/pull/1014#issuecomment-1899167622
A test is failing because log entries for configuration has it zero-copy buffer released too early ppening on #1021 for a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1934. Support Zero-Copy in GrpcServerProtocolService [ratis]
Posted by "duongkame (via GitHub)" <gi...@apache.org>.
duongkame commented on PR #1014:
URL: https://github.com/apache/ratis/pull/1014#issuecomment-1899182134
> #1021
Yes, pening
> @duongkame , The peer ids are corrupted; see https://github.com/apache/ratis/actions/runs/7573336528/job/20625244115?pr=1014#step:6:739
Yeah, pending fix by https://github.com/apache/ratis/pull/1021. @szetszwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1934. Support Zero-Copy in GrpcServerProtocolService [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1014:
URL: https://github.com/apache/ratis/pull/1014#issuecomment-1899178794
@duongkame , The peer ids are corrupted; see https://github.com/apache/ratis/actions/runs/7573336528/job/20625244115?pr=1014#step:6:739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1934. Support Zero-Copy in GrpcServerProtocolService [ratis]
Posted by "duongkame (via GitHub)" <gi...@apache.org>.
duongkame commented on PR #1014:
URL: https://github.com/apache/ratis/pull/1014#issuecomment-1899872421
RATIS-2009 is done. Merge from master fixed the problem with peer ids corrupted. @szetszwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1934. Support Zero-Copy in GrpcServerProtocolService [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo merged PR #1014:
URL: https://github.com/apache/ratis/pull/1014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org