You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Keegan Witt <ke...@gmail.com> on 2014/10/02 22:58:05 UTC
Review Request 26280: SQOOP-1403
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26280/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-trunk
Description
-------
SQOOP-1403_3.patch review
Diffs
-----
COMPILING.txt 138dc0a
src/java/org/apache/sqoop/manager/SQLServerManager.java fdd4e91
src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormat.java PRE-CREATION
src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java 1d4534b
src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
src/test/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormatTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/26280/diff/
Testing
-------
* Tested against our (eBay Enterprise's) SQL Server instances by including these changes in a jar that I forced to be first on the classpath.
* Successfully ran new unit and integration tests.
Thanks,
Keegan Witt
Re: Review Request 26280: SQOOP-1403
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26280/#review58295
-----------------------------------------------------------
Ship it!
+1
- Venkat Ranganathan
On Oct. 2, 2014, 8:58 p.m., Keegan Witt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26280/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 8:58 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-1403_3.patch review
>
>
> Diffs
> -----
>
> COMPILING.txt 138dc0a
> src/java/org/apache/sqoop/manager/SQLServerManager.java fdd4e91
> src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormat.java PRE-CREATION
> src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java 1d4534b
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
> src/test/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormatTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26280/diff/
>
>
> Testing
> -------
>
> * Tested against our (eBay Enterprise's) SQL Server instances by including these changes in a jar that I forced to be first on the classpath.
> * Successfully ran new unit and integration tests.
>
>
> Thanks,
>
> Keegan Witt
>
>
Re: Review Request 26280: SQOOP-1403
Posted by Keegan Witt <ke...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26280/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 4:58 p.m.)
Review request for Sqoop.
Repository: sqoop-trunk
Description
-------
SQOOP-1403_3.patch review
Diffs
-----
COMPILING.txt 138dc0a
src/java/org/apache/sqoop/manager/SQLServerManager.java fdd4e91
src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormat.java PRE-CREATION
src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java 1d4534b
src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
src/test/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormatTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/26280/diff/
Testing
-------
* Tested against our (eBay Enterprise's) SQL Server instances by including these changes in a jar that I forced to be first on the classpath.
* Successfully ran new unit and integration tests.
Thanks,
Keegan Witt
Re: Review Request 26280: SQOOP-1403
Posted by Keegan Witt <ke...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26280/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 4:58 p.m.)
Review request for Sqoop.
Repository: sqoop-trunk
Description
-------
SQOOP-1403_3.patch review
Diffs
-----
COMPILING.txt 138dc0a
src/java/org/apache/sqoop/manager/SQLServerManager.java fdd4e91
src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormat.java PRE-CREATION
src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java 1d4534b
src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
src/test/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormatTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/26280/diff/
Testing
-------
* Tested against our (eBay Enterprise's) SQL Server instances by including these changes in a jar that I forced to be first on the classpath.
* Successfully ran new unit and integration tests.
Thanks,
Keegan Witt
Re: Review Request 26280: SQOOP-1403
Posted by Keegan Witt <ke...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26280/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 4:58 p.m.)
Review request for Sqoop.
Repository: sqoop-trunk
Description
-------
SQOOP-1403_3.patch review
Diffs
-----
COMPILING.txt 138dc0a
src/java/org/apache/sqoop/manager/SQLServerManager.java fdd4e91
src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormat.java PRE-CREATION
src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java 1d4534b
src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
src/test/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormatTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/26280/diff/
Testing
-------
* Tested against our (eBay Enterprise's) SQL Server instances by including these changes in a jar that I forced to be first on the classpath.
* Successfully ran new unit and integration tests.
Thanks,
Keegan Witt
Re: Review Request 26280: SQOOP-1403
Posted by Keegan Witt <ke...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26280/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 4:58 p.m.)
Review request for Sqoop.
Repository: sqoop-trunk
Description
-------
SQOOP-1403_3.patch review
Diffs
-----
COMPILING.txt 138dc0a
src/java/org/apache/sqoop/manager/SQLServerManager.java fdd4e91
src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormat.java PRE-CREATION
src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java 1d4534b
src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
src/test/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormatTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/26280/diff/
Testing
-------
* Tested against our (eBay Enterprise's) SQL Server instances by including these changes in a jar that I forced to be first on the classpath.
* Successfully ran new unit and integration tests.
Thanks,
Keegan Witt