[jira] [Closed] (SLING-4250) Configuration values should be compared by string comparison

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler closed SLING-4250.
-----------------------------------

> Configuration values should be compared by string comparison
> ------------------------------------------------------------
>
>                 Key: SLING-4250
>                 URL: https://issues.apache.org/jira/browse/SLING-4250
>             Project: Sling
>          Issue Type: Improvement
>          Components: Installer
>    Affects Versions: Installer Configuration Factory 1.0.14
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Installer Configuration Factory 1.1.0
>
>
> ConfigUtil.isSameData has some logic which compares two configuration dictionaries:
> - if the value from dictionary A is a number, a special handling is done which results in string compare if the value from B is a number as well
> - otherwise equals is used
> Now, if A contains a string and B contains a number, both representing the same value, the dictionaries are considered to be not the same; the special handling is questionable as it only works in one direction.
> I think we can relax this and always do a string compare



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)