You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by "Sanjays2402 (via GitHub)" <gi...@apache.org> on 2026/10/05 00:23:09 UTC
[PR] Use a string NodeImage name in the custom AMI example [libcloud]
Sanjays2402 opened a new pull request, #2190:
URL: https://github.com/apache/libcloud/pull/2190
### Description
Fixes #2075.
The custom EC2 AMI example passes `name=None` to `NodeImage`, whose documented type is `str`. Use `"Netflix Asgard"`, matching the image described in the example. The AMI ID and driver configuration are unchanged.
Validation: executed the complete example with a mock driver and verified the real `NodeImage` passed to `create_node` has the expected string name, AMI ID, and driver. Black and `git diff --check` passed. Prepared with Codex.
### Status
done, ready for review
### Checklist
- [x] Code linting
- [x] Documentation
- [x] Tests (example exercised with a mock driver)
- [ ] ICLA (documentation-only change)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use a string NodeImage name in the custom AMI example [libcloud]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2190:
URL: https://github.com/apache/libcloud/pull/2190#issuecomment-6214378193
## [Codecov](https://app.codecov.io/gh/apache/libcloud/pull/2190?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 83.61%. Comparing base ([`cddf127`](https://app.codecov.io/gh/apache/libcloud/commit/cddf127751d21a6e1359db5ea28cc4f7c90a10f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`58f0c25`](https://app.codecov.io/gh/apache/libcloud/commit/58f0c25a2f5a4622b97a7a7cdd2b77ca17bf1409?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## trunk #2190 +/- ##
=======================================
Coverage 83.61% 83.61%
=======================================
Files 352 352
Lines 82045 82045
Branches 8799 8799
=======================================
Hits 68599 68599
Misses 10565 10565
Partials 2881 2881
```
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use a string NodeImage name in the custom AMI example [libcloud]
Posted by "micafer (via GitHub)" <gi...@apache.org>.
micafer merged PR #2190:
URL: https://github.com/apache/libcloud/pull/2190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org