You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/04/12 07:42:45 UTC
[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #412:
nimble/host: Couple of improvements around periodic adv
sjanc commented on a change in pull request #412: nimble/host: Couple of improvements around periodic adv
URL: https://github.com/apache/mynewt-nimble/pull/412#discussion_r274792054
##########
File path: nimble/host/src/ble_hs_stop.c
##########
@@ -80,24 +81,18 @@ ble_hs_stop_terminate_next_periodic_sync(void)
* removed from the list such that the next call to
* ble_hs_periodic_sync_first yields the next psync handle
*/
- rc = ble_gap_periodic_adv_terminate_sync(psync->sync_handle);
-
- if (!rc){
- BLE_HS_LOG(ERROR,
- "ble_hs_stop: failed to terminate connection; rc=%d\n",
- rc);
- ble_hs_stop_done(rc);
+ sync_handle = psync->sync_handle;
+ rc = ble_gap_periodic_adv_terminate_sync(sync_handle);
+ if (!rc) {
Review comment:
this looks odd, zero rc is an error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services