[GitHub] [incubator-devlake] mappjzc commented on a diff in pull request #2566: fix: jobs miss type field

[GitBox <gi...@apache.org>]

mappjzc commented on code in PR #2566:
URL: https://github.com/apache/incubator-devlake/pull/2566#discussion_r926494561


##########
plugins/jenkins/tasks/job_convertor.go:
##########
@@ -71,6 +71,7 @@ func ConvertJobs(taskCtx core.SubTaskContext) error {
 					Id: jobIdGen.Generate(jenkinsJob.ConnectionId, jenkinsJob.Name),
 				},
 				Name: jenkinsJob.Name,
+				Type: jenkinsJob.Class,

Review Comment:
   maybe we can keep the filed name `class`



##########
models/migrationscripts/register.go:
##########
@@ -28,5 +28,6 @@ func All() []migration.Script {
 		new(updateBlueprintMode),
 		new(renameTasksToPlan),
 		new(addDomainTables),
+		new(addTypeField),

Review Comment:
   it might should add to /plugins/jenkins/models/migrationscripts



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org