You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/05/02 03:40:53 UTC
Review Request: Implemented os::pids() for OSX.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10896/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
See above.
Diffs
-----
third_party/libprocess/third_party/stout/include/stout/os/osx.hpp PRE-CREATION
third_party/libprocess/third_party/stout/tests/os_tests.cpp 047778d05ebbbefd85e4a163dbb6ab8445edfb7f
Diff: https://reviews.apache.org/r/10896/diff/
Testing
-------
make check on OSX and Linux.
Thanks,
Ben Mahler
Re: Review Request: Implemented os::pids() for OSX.
Posted by Ben Mahler <be...@gmail.com>.
> On May 8, 2013, 5:47 p.m., Benjamin Hindman wrote:
> > This review really screams for an os::sysctl helper. I've got something in mind I'll send your way.
Cool, I can take this on top of these changes if you want to pass it over.
Will be discarding and sending out a separate chain for this due to the restructuring.
> On May 8, 2013, 5:47 p.m., Benjamin Hindman wrote:
> > third_party/libprocess/third_party/stout/include/stout/os/osx.hpp, line 85
> > <https://reviews.apache.org/r/10896/diff/1/?file=286972#file286972line85>
> >
> > delete[]
Good catch, thanks!
> On May 8, 2013, 5:47 p.m., Benjamin Hindman wrote:
> > third_party/libprocess/third_party/stout/include/stout/os/osx.hpp, line 99
> > <https://reviews.apache.org/r/10896/diff/1/?file=286972#file286972line99>
> >
> > delete[]
Phew, thanks for catching this!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10896/#review20295
-----------------------------------------------------------
On May 2, 2013, 1:40 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10896/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 1:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/os/osx.hpp PRE-CREATION
> third_party/libprocess/third_party/stout/tests/os_tests.cpp 047778d05ebbbefd85e4a163dbb6ab8445edfb7f
>
> Diff: https://reviews.apache.org/r/10896/diff/
>
>
> Testing
> -------
>
> make check on OSX and Linux.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Implemented os::pids() for OSX.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10896/#review20295
-----------------------------------------------------------
This review really screams for an os::sysctl helper. I've got something in mind I'll send your way.
third_party/libprocess/third_party/stout/include/stout/os/osx.hpp
<https://reviews.apache.org/r/10896/#comment41830>
s/pointer,/pointer/
third_party/libprocess/third_party/stout/include/stout/os/osx.hpp
<https://reviews.apache.org/r/10896/#comment41832>
Two thoughts:
(1) Why not provide __FILE__ and __LINE__ so people could easily find the context?
(2) Why not express in English what you believe to be wrong rather than in code (which I can clearly read once I find the __FILE__ and __LINE__). For example:
<< "Failed to determine the maximum number of processes allowed in the system, expecting output to be " << sizeof(maximumProcesses) << " bytes but instead output was " << resultSize << " bytes";
third_party/libprocess/third_party/stout/include/stout/os/osx.hpp
<https://reviews.apache.org/r/10896/#comment41831>
delete[]
third_party/libprocess/third_party/stout/include/stout/os/osx.hpp
<https://reviews.apache.org/r/10896/#comment41878>
delete[]
- Benjamin Hindman
On May 2, 2013, 1:40 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10896/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 1:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/os/osx.hpp PRE-CREATION
> third_party/libprocess/third_party/stout/tests/os_tests.cpp 047778d05ebbbefd85e4a163dbb6ab8445edfb7f
>
> Diff: https://reviews.apache.org/r/10896/diff/
>
>
> Testing
> -------
>
> make check on OSX and Linux.
>
>
> Thanks,
>
> Ben Mahler
>
>