[GitHub] [hudi] codope commented on a diff in pull request #9071: [HUDI-6453] Cascade Glue schema changes to partitions

["codope (via GitHub)" <gi...@apache.org>]

codope commented on code in PR #9071:
URL: https://github.com/apache/hudi/pull/9071#discussion_r1292982378


##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -330,7 +312,6 @@ && getTable(awsGlue, databaseName, tableName).getPartitionKeys().equals(partitio
 
   @Override
   public void updateTableSchema(String tableName, MessageType newSchema) {
-    // ToDo Cascade is set in Hive meta sync, but need to investigate how to configure it for Glue meta
     boolean cascade = config.getSplitStrings(META_SYNC_PARTITION_FIELDS).size() > 0;

Review Comment:
   +1 only cascade when necessary. Cascading could adversely impact sync latency when there are tens of thousands of partitions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org