You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/14 08:44:53 UTC

[GitHub] [pulsar] MarvinCai opened a new pull request #10225: Fix entry cache size update logic so it won't go negative.

MarvinCai opened a new pull request #10225:
URL: https://github.com/apache/pulsar/pull/10225


   Fixes #10016
   
   ### Motivation
   Metrics `pulsar_ml_cache_used_size` can to negative sometime.
   
   ### Modifications
   Only place where we could subtract more from the cache size then we add to it is when an EntryCache is cleared, the returned value is not the size of entries removed but the size of cache before clear(). Update the behavior here to return the size of entries removed.
   
   ### Verifying this change
   Added unit test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10225: Fix entry cache size update logic so it won't go negative.

Posted by GitBox <gi...@apache.org>.

merlimat merged pull request #10225:
URL: https://github.com/apache/pulsar/pull/10225


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org