You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/07 06:01:31 UTC

[GitHub] [hudi] ThinkerLei commented on a diff in pull request #6384: [HUDI-4613] Avoid the use of regex expressions when call hoodieFileGroup#addLogFile function

ThinkerLei commented on code in PR #6384:
URL: https://github.com/apache/hudi/pull/6384#discussion_r964412660


##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieLogFile.java:
##########
@@ -98,7 +111,10 @@ public String getFileExtension() {
   }
 
   public Path getPath() {
-    return new Path(pathStr);
+    if (path == null) {
+      this.path = new Path(pathStr);

Review Comment:
   @yihua Thanks for your comments and suggestions，I have taken your suggestion and submitted again.  I haven't compared the memory usage before and after the patch in time. But with four new variables we can roughly estimate the  memory usage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org