[superset] branch master updated: chore: updated base DAO find_by_id to return generic type (#25726)

[cr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

craigrueda pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 4aef771072 chore: updated base DAO find_by_id to return generic type (#25726)
4aef771072 is described below

commit 4aef7710725a1813a43b438454a7b1ddb8b8ebf8
Author: Zef Lin <ze...@preset.io>
AuthorDate: Mon Oct 23 07:46:01 2023 -0700

    chore: updated base DAO find_by_id to return generic type (#25726)
---
 superset/daos/base.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/daos/base.py b/superset/daos/base.py
index a69f07da5d..d2c1842c17 100644
--- a/superset/daos/base.py
+++ b/superset/daos/base.py
@@ -62,7 +62,7 @@ class BaseDAO(Generic[T]):
         model_id: str | int,
         session: Session = None,
         skip_base_filter: bool = False,
-    ) -> Model | None:
+    ) -> T | None:
         """
         Find a model by id, if defined applies `base_filter`
         """