[GitHub] [incubator-livy] andrasbeni commented on a change in pull request #289: [WIP] [LIVY-756] Add Support Spark 3

[GitBox <gi...@apache.org>]

andrasbeni commented on a change in pull request #289:
URL: https://github.com/apache/incubator-livy/pull/289#discussion_r434684045



##########
File path: api/src/main/java/org/apache/livy/JobContext.java
##########
@@ -41,12 +40,12 @@
   /**
    * @return The shared SQLContext instance.
    */
-  SQLContext sqlctx();
+  SQLContext sqlctx() throws Exception ;
 
   /**
-   * @return The shared HiveContext instance.
+   * @return The shared hive SQLContext instance.
    */
-  HiveContext hivectx();

Review comment:
       This will break compatibility to those who keep using Livy with Spark 2.4.
   I'd recommend to maintain two versions of this file and adding the correct version to compile sources based on profiles. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org