You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/28 10:46:39 UTC
[GitHub] [flink] huwh opened a new pull request, #21569: [FLINK-30517][log]Decrease log output interval while waiting for YARN…
huwh opened a new pull request, #21569:
URL: https://github.com/apache/flink/pull/21569
… JobManager be allocated.
## What is the purpose of the change
Flink Client will retrieve the application status every 250ms after submitting to YARN.
If JobManager does not start in 60 seconds, it will log "Deployment took more than 60 seconds. Please check if the requested resources are available in the YARN cluster" every 250ms. This will lead to too many logs.
We can keep the check interval at 250ms, but log the message every 1 minute.
## Brief change log
- *Decrease log output interval while waiting for YARN JobManager be allocated*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21569: [FLINK-30517][log]Decrease log output interval while waiting for YARN…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21569:
URL: https://github.com/apache/flink/pull/21569#issuecomment-1366560907
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2604f197ea7d721c0eecfe7e9c2fbafc810009ae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2604f197ea7d721c0eecfe7e9c2fbafc810009ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2604f197ea7d721c0eecfe7e9c2fbafc810009ae UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] huwh commented on pull request #21569: [FLINK-30517][log]Decrease log output interval while waiting for YARN…
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh commented on PR #21569:
URL: https://github.com/apache/flink/pull/21569#issuecomment-1437910655
@xintongsong Hi, Could you help take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] huwh commented on a diff in pull request #21569: [FLINK-30517][log]Decrease log output interval while waiting for YARN…
Posted by GitBox <gi...@apache.org>.
huwh commented on code in PR #21569:
URL: https://github.com/apache/flink/pull/21569#discussion_r1058341817
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -1264,9 +1265,11 @@ private ApplicationReport startAppMaster(
if (appState != lastAppState) {
LOG.info("Deploying cluster, current state " + appState);
}
- if (System.currentTimeMillis() - startTime > 60000) {
+ if (System.currentTimeMillis() - lastLogTime > 60000) {
+ lastLogTime = System.currentTimeMillis();
LOG.info(
- "Deployment took more than 60 seconds. Please check if the requested resources are available in the YARN cluster");
Review Comment:
addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] X-czh commented on a diff in pull request #21569: [FLINK-30517][log]Decrease log output interval while waiting for YARN…
Posted by GitBox <gi...@apache.org>.
X-czh commented on code in PR #21569:
URL: https://github.com/apache/flink/pull/21569#discussion_r1058296234
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -1264,9 +1265,11 @@ private ApplicationReport startAppMaster(
if (appState != lastAppState) {
LOG.info("Deploying cluster, current state " + appState);
}
- if (System.currentTimeMillis() - startTime > 60000) {
+ if (System.currentTimeMillis() - lastLogTime > 60000) {
+ lastLogTime = System.currentTimeMillis();
LOG.info(
- "Deployment took more than 60 seconds. Please check if the requested resources are available in the YARN cluster");
Review Comment:
lastLogTime is in millisesecond, but the logging time is in seconds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa merged pull request #21569: [FLINK-30517][log]Decrease log output interval while waiting for YARN…
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa merged PR #21569:
URL: https://github.com/apache/flink/pull/21569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org