You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/08/09 16:49:19 UTC

[GitHub] [incubator-kyuubi] BoyangYue opened a new pull request #910: [KYUUBI #905] [MINOR] clear handleToTSessionHandle in KyuubiOperationManager

BoyangYue opened a new pull request #910:
URL: https://github.com/apache/incubator-kyuubi/pull/910


   
   
   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   To clear deprecated handleToTSessionHandle in KyuubiOperationManager.
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [x] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] byyue commented on pull request #910: [KYUUBI #905] [MINOR] clear handleToTSessionHandle in KyuubiOperationManager

Posted by GitBox <gi...@apache.org>.
byyue commented on pull request #910:
URL: https://github.com/apache/incubator-kyuubi/pull/910#issuecomment-902436439


   > Yeah, I see. BTW, in some cases, I think that reuse the existing PR is a better choise instead of open a new one.
   
   Got it. By the way, since I'm still a beginner in Scala, feel free to assign me some more trivial tasks so that I can get familiar with this project and contribute gradually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] BoyangYue closed pull request #910: [KYUUBI #905] [MINOR] clear handleToTSessionHandle in KyuubiOperationManager

Posted by GitBox <gi...@apache.org>.
BoyangYue closed pull request #910:
URL: https://github.com/apache/incubator-kyuubi/pull/910


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #910: [KYUUBI #905] [MINOR] clear handleToTSessionHandle in KyuubiOperationManager

Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #910:
URL: https://github.com/apache/incubator-kyuubi/pull/910#issuecomment-902362259


   Yeah, I see. BTW, in some cases, I think that reuse the existing PR is a better choise instead of open a new one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #910: [KYUUBI #905] [MINOR] clear handleToTSessionHandle in KyuubiOperationManager

Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #910:
URL: https://github.com/apache/incubator-kyuubi/pull/910#issuecomment-902437649


   Thanks for your enthusiasm for the Scala and Kyuubi community.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #910: [KYUUBI #905] [MINOR] clear handleToTSessionHandle in KyuubiOperationManager

Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #910:
URL: https://github.com/apache/incubator-kyuubi/pull/910#issuecomment-902437649


   Thank you for your enthusiasm for the Scala and Kyuubi community.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] byyue commented on pull request #910: [KYUUBI #905] [MINOR] clear handleToTSessionHandle in KyuubiOperationManager

Posted by GitBox <gi...@apache.org>.
byyue commented on pull request #910:
URL: https://github.com/apache/incubator-kyuubi/pull/910#issuecomment-901963334


   @pan3793 Hi, another better version has been merged to master. See https://github.com/apache/incubator-kyuubi/pull/911.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org