[kudu-CR] cfile-test: add a 100M-string file with low cardinality

["Todd Lipcon (Code Review)" <ge...@cloudera.org>]

Todd Lipcon has posted comments on this change.

Change subject: cfile-test: add a 100M-string file with low cardinality
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6432/1/src/kudu/cfile/cfile-test-base.h
File src/kudu/cfile/cfile-test-base.h:

PS1, Line 372: to match
             :     // the output block size of compaction.
> Ah, got it. May be worth adding extra context to the comment, something alo
k, I pulled out a constant and then referred to it here in the comment. Unfortunately I couldn't actually make the _code_ refer to it, because I didn't want to introduce a backwards dependency from cfile/ -> tablet/, but at least now it's more clear.


http://gerrit.cloudera.org:8080/#/c/6432/1/src/kudu/cfile/cfile-test.cc
File src/kudu/cfile/cfile-test.cc:

Line 35: #include "kudu/util/test_macros.h"
> warning: #includes are not sorted properly [llvm-include-order]
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c92f3b6c04c4c2ef50497ad1dc1380b7152d9e9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes