You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2017/07/01 13:49:00 UTC
[jira] [Comment Edited] (THRIFT-4238) JSON generator: make
annotation-aware
[ https://issues.apache.org/jira/browse/THRIFT-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071237#comment-16071237 ]
Jens Geyer edited comment on THRIFT-4238 at 7/1/17 1:48 PM:
------------------------------------------------------------
GitHub user stigsb opened a pull request:
https://github.com/apache/thrift/pull/1299
THRIFT-4328: Make JSON generator annotation-aware
This PR adds annotations to the JSON generator's output, for enums, structs, services, fields as well as nested types. Also tightened up the JSON schema a bit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stigsb/thrift THRIFT-4328
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1299
----
commit 28462161bc40167ffda60601908a5506b7181d4f
Author: Stig Bakken <st...@zedge.net>
Date: 2017-06-27T08:51:37Z
Make JSON generator annotation-aware
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
was (Author: jensg):
GitHub user stigsb opened a pull request: https://github.com/apache/thrift/pull/1299
THRIFT-4328: Make JSON generator annotation-aware This PR adds
annotations to the JSON generator's output, for enums, structs, services, fields
as well as nested types. Also tightened up the JSON schema a bit.You can
merge this pull request into a Git repository by running: $ git pull
https://github.com/stigsb/thrift
THRIFT-4328Alternatively you can review and apply these changes as the
patch at: https://github.com/apache/thrift/pull/1299.patchTo
close this pull request, make a commit to your master/trunk branchwith (at
least) the following in the commit message: This closes #1299
----commit 28462161bc40167ffda60601908a5506b7181d4fAuthor: Stig
Bakken <st...@zedge.net>Date:
2017-06-27T08:51:37Z Make JSON generator
annotation-aware-------If your project is set up for it,
you can reply to this email and have yourreply appear on GitHub as well. If
your project does not have this featureenabled and wishes so, or if the
feature is enabled but not working, pleasecontact infrastructure at infrastructure@apache.org or file a
JIRA ticketwith INFRA.---
> JSON generator: make annotation-aware
> -------------------------------------
>
> Key: THRIFT-4238
> URL: https://issues.apache.org/jira/browse/THRIFT-4238
> Project: Thrift
> Issue Type: Improvement
> Components: JSON - Compiler
> Affects Versions: 0.10.0
> Reporter: Stig Bakken
> Priority: Minor
>
> This PR adds annotations to the JSON generator's output, for enums, structs, services, fields as well as nested types. Also tightened up the JSON schema a bit.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)