You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2023/04/27 07:34:31 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
BiteTheDDDDt opened a new pull request, #19155:
URL: https://github.com/apache/doris/pull/19155
# Proposed changes
1. upgrade clang-format version to 16
2. move thrift to fe-common
3. fix core dump on pipeline engine when operator canceled and not prepared
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1525138610
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4817771228") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build-for-release.sh line 96:
exit 0
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build-for-release.sh line 102:
exit 1
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 235:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build_plugin.sh line 92:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In contrib/udf/build_udf.sh line 105:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In run-regression-test.sh line 114:
exit 1
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In samples/insert/shell/insert_utils.sh line 50:
break
^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/restore_tablet_tool.sh line 89:
shift
^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/create-ssb-tables.sh line 76:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/gen-ssb-data.sh line 93:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/load-ssb-data.sh line 86:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 75:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/run-ssb-queries.sh line 75:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/create-tpch-tables.sh line 73:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/gen-tpch-data.sh line 93:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/load-tpch-data.sh line 86:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/run-tpch-queries.sh line 74:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
For more information:
https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1525178558
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4817900658") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In samples/insert/shell/insert_utils.sh line 50:
break
^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/restore_tablet_tool.sh line 89:
shift
^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/create-ssb-tables.sh line 76:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
For more information:
https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1526893077
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1526893097
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1524983916
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1526841881
Please explain why upgrading this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #19155:
URL: https://github.com/apache/doris/pull/19155#discussion_r1178839107
##########
be/src/pipeline/exec/operator.h:
##########
@@ -42,13 +42,15 @@ class RuntimeState;
class TDataSink;
} // namespace doris
-#define OPERATOR_CODE_GENERATOR(NAME, SUBCLASS) \
- NAME##Builder::NAME##Builder(int32_t id, ExecNode* exec_node) \
- : OperatorBuilder(id, #NAME, exec_node) {} \
- \
- OperatorPtr NAME##Builder::build_operator() { return std::make_shared<NAME>(this, _node); } \
- \
- NAME::NAME(OperatorBuilderBase* operator_builder, ExecNode* node) \
+#define OPERATOR_CODE_GENERATOR(NAME, SUBCLASS) \
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define OPERATOR_CODE_GENERATOR(NAME, SUBCLASS) \
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1525059019
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4817455593") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In bin/start_fe.sh line 111:
JAVA="$(which java)"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In build-for-release.sh line 97:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build-for-release.sh line 103:
exit 1
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build-support/check-format.sh line 34:
CLANG_FORMAT="${CLANG_FORMAT_BINARY:=$(which clang-format)}"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In build-support/clang-format.sh line 34:
CLANG_FORMAT="${CLANG_FORMAT_BINARY:=$(which clang-format)}"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In build.sh line 235:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 435:
MAKE_PROGRAM="$(which "${BUILD_SYSTEM}")"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In build_plugin.sh line 92:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In contrib/udf/build_udf.sh line 105:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In dist/download_scripts/download_base.sh line 42:
if [[ -n $(which curl >/dev/null 2>&1) ]]; then
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In env.sh line 120:
DORIS_GCC_HOME="$(dirname "$(which gcc)")"/..
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In env.sh line 138:
DORIS_CLANG_HOME="$(dirname "$(which clang)")"/..
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In env.sh line 166:
DORIS_GCC_HOME="$(dirname "$(which gcc)")/.."
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In env.sh line 194:
JAVA="$(which java)"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In env.sh line 195:
JAVAP="$(which javap)"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In fs_brokers/apache_hdfs_broker/bin/start_broker.sh line 70:
JAVA="$(which java)"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In gensrc/script/gen_build_version.sh line 79:
java_cmd="$(which java)"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In run-be-ut.sh line 181:
MAKE_PROGRAM="$(which "${BUILD_SYSTEM}")"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In run-regression-test.sh line 114:
exit 1
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In samples/insert/shell/insert_utils.sh line 50:
break
^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/restore_tablet_tool.sh line 89:
shift
^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/create-ssb-tables.sh line 76:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/gen-ssb-data.sh line 93:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/load-ssb-data.sh line 86:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 75:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/run-ssb-queries.sh line 75:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/create-tpch-tables.sh line 73:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/gen-tpch-data.sh line 93:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/load-tpch-data.sh line 86:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/run-tpch-queries.sh line 74:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
For more information:
https://www.shellcheck.net/wiki/SC2230 -- 'which' is non-standard. Use buil...
https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1525211472
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1525056919
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1525057659
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4817452726") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In bin/start_fe.sh line 111:
JAVA="$(which java)"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In build-for-release.sh line 97:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build-for-release.sh line 103:
exit 1
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build-support/check-format.sh line 34:
CLANG_FORMAT="${CLANG_FORMAT_BINARY:=$(which clang-format)}"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In build-support/clang-format.sh line 34:
CLANG_FORMAT="${CLANG_FORMAT_BINARY:=$(which clang-format)}"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In build.sh line 235:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 435:
MAKE_PROGRAM="$(which "${BUILD_SYSTEM}")"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In build_plugin.sh line 92:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In contrib/udf/build_udf.sh line 105:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In dist/download_scripts/download_base.sh line 42:
if [[ -n $(which curl >/dev/null 2>&1) ]]; then
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In env.sh line 120:
DORIS_GCC_HOME="$(dirname "$(which gcc)")"/..
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In env.sh line 138:
DORIS_CLANG_HOME="$(dirname "$(which clang)")"/..
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In env.sh line 166:
DORIS_GCC_HOME="$(dirname "$(which gcc)")/.."
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In env.sh line 194:
JAVA="$(which java)"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In env.sh line 195:
JAVAP="$(which javap)"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In fs_brokers/apache_hdfs_broker/bin/start_broker.sh line 70:
JAVA="$(which java)"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In gensrc/script/gen_build_version.sh line 79:
java_cmd="$(which java)"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In run-be-ut.sh line 181:
MAKE_PROGRAM="$(which "${BUILD_SYSTEM}")"
^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
In run-regression-test.sh line 114:
exit 1
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In samples/insert/shell/insert_utils.sh line 50:
break
^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/restore_tablet_tool.sh line 89:
shift
^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/create-ssb-tables.sh line 76:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/gen-ssb-data.sh line 93:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/load-ssb-data.sh line 86:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 75:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/run-ssb-queries.sh line 75:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/create-tpch-tables.sh line 73:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/gen-tpch-data.sh line 93:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/load-tpch-data.sh line 86:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/run-tpch-queries.sh line 74:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
For more information:
https://www.shellcheck.net/wiki/SC2230 -- 'which' is non-standard. Use buil...
https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1525185406
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1526876598
>
> Please explain why upgrading this
The latest ldb toolchain (0.17) has upgraded clang to 16 and works well on doris, so I updated the relevant documents and workflow accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1525098975
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.74 seconds
stream load tsv: 424 seconds loaded 74807831229 Bytes, about 168 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230427082340_clickbench_pr_136389.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #19155:
URL: https://github.com/apache/doris/pull/19155#discussion_r1178745986
##########
be/src/common/factory_creator.h:
##########
@@ -35,21 +35,33 @@
// during inherits
// TODO try to allow make_unique
//
-#define ENABLE_FACTORY_CREATOR(TypeName) \
-private: \
- void* operator new(std::size_t size) { return ::operator new(size); } \
- void* operator new[](std::size_t size) { return ::operator new[](size); } \
- \
-public: \
- void* operator new(std::size_t count, void* ptr) { return ::operator new(count, ptr); } \
- void operator delete(void* ptr) noexcept { ::operator delete(ptr); } \
- void operator delete[](void* ptr) noexcept { ::operator delete[](ptr); } \
- void operator delete(void* ptr, void* place) noexcept { ::operator delete(ptr, place); } \
- template <typename... Args> \
- static std::shared_ptr<TypeName> create_shared(Args&&... args) { \
- return std::make_shared<TypeName>(std::forward<Args>(args)...); \
- } \
- template <typename... Args> \
- static std::unique_ptr<TypeName> create_unique(Args&&... args) { \
- return std::unique_ptr<TypeName>(new TypeName(std::forward<Args>(args)...)); \
+#define ENABLE_FACTORY_CREATOR(TypeName) \
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define ENABLE_FACTORY_CREATOR(TypeName) \
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19155:
URL: https://github.com/apache/doris/pull/19155#issuecomment-1525160841
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4817842437") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build-for-release.sh line 96:
exit 0
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build-for-release.sh line 102:
exit 1
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 235:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build_plugin.sh line 93:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In contrib/udf/build_udf.sh line 105:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In run-regression-test.sh line 114:
exit 1
^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In samples/insert/shell/insert_utils.sh line 50:
break
^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/restore_tablet_tool.sh line 89:
shift
^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/create-ssb-tables.sh line 76:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/gen-ssb-data.sh line 93:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/load-ssb-data.sh line 86:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 75:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/ssb-tools/bin/run-ssb-queries.sh line 75:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/create-tpch-tables.sh line 73:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/gen-tpch-data.sh line 93:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/load-tpch-data.sh line 86:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In tools/tpch-tools/bin/run-tpch-queries.sh line 74:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
For more information:
https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19155: [Chore](build) upgrade clang-format version to 16 && move thrift to fe-common
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #19155:
URL: https://github.com/apache/doris/pull/19155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org