You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/14 07:29:10 UTC

[GitHub] [airflow] ARtheboss opened a new issue #16986: Retrying a task from inside task instance view

ARtheboss opened a new issue #16986:
URL: https://github.com/apache/airflow/issues/16986

<!--

Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)

If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>

Please delete these comment blocks before submitting the issue.

-->

**Description**

Users should be able to clear a task along with all downstream tasks from the Task Instance page (especially the log subpage). In other words, we should be able to get a similar menu to the one that appears when you click on a task square from tree view on the Task Instance page.

**Use case / motivation**

This will make it easier to retry a task and will require less clicks (users won't have to go into the tree/graph page and then clear from there).

**Are you willing to submit a PR?**

No

**Related Issues**

None

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on issue #16986: Retrying a task from inside task instance view

Posted by GitBox <gi...@apache.org>.

uranusjr commented on issue #16986:
URL: https://github.com/apache/airflow/issues/16986#issuecomment-880418133


   If you already know some Flask, what you need to do is to add a form in the UI that POST to a new view. That view should take the current task instance’s id, select it out, set its state to `UP_FOR_RETRY`, and then redirect back to the task instance view, similar to `TaskInstanceModelView.action_set_retry` (actually you can just post to that view, but the view is built against Flask-Appbuilder and manually POST-ing to it is a giant PITA that I strongly recommended against).
   
   The form should look something like this:
   
   ```html
   <form action="{{ url_for('name_of_view') }}" method="POST">
     <input type="hidden" name="csrf_token" value="{{ csrf_token() }}">
     <input type="hidden" name="dag_id" value="{{ dag_id }}">
     <input type="hidden" name="task_id" value="{{ task_id }}">
     <button type="submit">Retry Task</button>
   </form>
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ARtheboss edited a comment on issue #16986: Retrying a task from inside task instance view

Posted by GitBox <gi...@apache.org>.

ARtheboss edited a comment on issue #16986:
URL: https://github.com/apache/airflow/issues/16986#issuecomment-879728070


   @potiuk Ok, I don't mind, just not sure how this works. Where are the relevant files for the web UI?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #16986: Retrying a task from inside task instance view

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #16986:
URL: https://github.com/apache/airflow/issues/16986#issuecomment-879853061


   No idea, I do not know that much of the UI. But I do not think it's as difficult - those are just HTML templates/javascript  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] zkan commented on issue #16986: Retrying a task from inside task instance view

Posted by GitBox <gi...@apache.org>.

zkan commented on issue #16986:
URL: https://github.com/apache/airflow/issues/16986#issuecomment-939484010


   @potiuk May I take this issue, please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on issue #16986: Retrying a task from inside task instance view

Posted by GitBox <gi...@apache.org>.

bbovenzi commented on issue #16986:
URL: https://github.com/apache/airflow/issues/16986#issuecomment-882444732


   [Here](https://github.com/apache/airflow/blob/main/airflow/www/templates/airflow/task_instance.html) is the html file for the task instance page. I'd start there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #16986: Retrying a task from inside task instance view

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #16986:
URL: https://github.com/apache/airflow/issues/16986#issuecomment-879711408


   Why not willing to implement it @ARtheboss ? Airflow is a community run project and a lot of users contribute to it, sounds like a simple change to implement? We are happy to guide you and help you with the contribution process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on issue #16986: Retrying a task from inside task instance view

Posted by GitBox <gi...@apache.org>.

bbovenzi commented on issue #16986:
URL: https://github.com/apache/airflow/issues/16986#issuecomment-882444732


   [Here](https://github.com/apache/airflow/blob/main/airflow/www/templates/airflow/task_instance.html) is the html file for the task instance page. I'd start there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on issue #16986: Retrying a task from inside task instance view

Posted by GitBox <gi...@apache.org>.

bbovenzi commented on issue #16986:
URL: https://github.com/apache/airflow/issues/16986#issuecomment-939484370


   @zkan go for it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #16986: Retrying a task from inside task instance view

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on issue #16986:
URL: https://github.com/apache/airflow/issues/16986#issuecomment-879663578


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #16986: Retrying a task from inside task instance view

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #16986:
URL: https://github.com/apache/airflow/issues/16986#issuecomment-879853278


   But there are others who might help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ARtheboss commented on issue #16986: Retrying a task from inside task instance view

Posted by GitBox <gi...@apache.org>.

ARtheboss commented on issue #16986:
URL: https://github.com/apache/airflow/issues/16986#issuecomment-879728070


   @potiuk Ok, I don't mind, just not sure how this works. Where are the relevant files in the web UI?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org