[GitHub] sijie closed pull request #1304: Make buildtools dependency in test scope and a few updates in PulsarClientImpl

[GitBox <gi...@apache.org>]

sijie closed pull request #1304: Make buildtools dependency in test scope and a few updates in PulsarClientImpl
URL: https://github.com/apache/incubator-pulsar/pull/1304
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 6b2dd0847..d77f1e836 100644
--- a/pom.xml
+++ b/pom.xml
@@ -600,6 +600,7 @@ flexible messaging model and an intuitive client API.</description>
       <groupId>org.apache.pulsar</groupId>
       <artifactId>buildtools</artifactId>
       <version>${project.version}</version>
+      <scope>test</scope>
     </dependency>
 
     <dependency>
diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
index a4b50ed12..c07ec8b2e 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
@@ -221,7 +221,7 @@ public Producer createProducer(final String topic, final ProducerConfiguration c
         }
 
         if (state.get() != State.Open) {
-            return FutureUtil.failedFuture(new PulsarClientException.AlreadyClosedException("Client already closed"));
+            return FutureUtil.failedFuture(new PulsarClientException.AlreadyClosedException("Client already closed : state = " + state.get()));
         }
 
         String topic = conf.getTopicName();
@@ -590,7 +590,8 @@ public void shutdown() throws PulsarClientException {
                 .thenCompose(pair -> cnxPool.getConnection(pair.getLeft(), pair.getRight()));
     }
 
-    protected Timer timer() {
+    /** visiable for pulsar-functions **/
+    public Timer timer() {
         return timer;
     }
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services