[jira] [Commented] (PHOENIX-1372) Fix resource leaks in various classes

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946998#comment-14946998 ] 

James Taylor commented on PHOENIX-1372:
---------------------------------------

[~samarthjain] - if you have a few cycles, would you min reviewing/committing?

[~tedyu@apache.org] - did you run maven verify to ensure all unit and integration tests pass?

> Fix resource leaks in various classes
> -------------------------------------
>
>                 Key: PHOENIX-1372
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1372
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>              Labels: resources
>         Attachments: 1372-v1.txt
>
>
> Statement / PreparedStatement should be closed after query completes.
> Below is an example of resource leak from MetaDataUtil#deleteViewIndexSequences():
> {code}
>      public static void deleteViewIndexSequences(PhoenixConnection connection, PName name) throws SQLException {
>          SequenceKey key = getViewIndexSequenceKey(null, name);
>         connection.createStatement().executeUpdate("DELETE FROM " + PhoenixDatabaseMetaData.SEQUENCE_TABLE_NAME +
> {code}
> The Statement created by connection.createStatement() should be closed upon return.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)