You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (JIRA)" <ji...@apache.org> on 2011/07/07 04:03:16 UTC
[jira] [Created] (LUCENE-3284) Move contribs/modules away from
QueryParser dependency
Move contribs/modules away from QueryParser dependency
------------------------------------------------------
Key: LUCENE-3284
URL: https://issues.apache.org/jira/browse/LUCENE-3284
Project: Lucene - Java
Issue Type: Sub-task
Components: core/queryparser, modules/queryparser
Reporter: Chris Male
Some contribs and modules depend on the core QueryParser just for simplicity in their tests. We should apply the same process as I did to the core tests, and move them away from using the QueryParser where possible.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3284) Move contribs/modules away from
QueryParser dependency
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061238#comment-13061238 ]
Chris Male commented on LUCENE-3284:
------------------------------------
After looking at the analysis-common dependencies, I think they can be refactored out. There isn't any need to actually form Querys, the same testing can be done by asserting the tokenstream contents. I'll work on those and upload a new patch.
> Move contribs/modules away from QueryParser dependency
> ------------------------------------------------------
>
> Key: LUCENE-3284
> URL: https://issues.apache.org/jira/browse/LUCENE-3284
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/queryparser, modules/queryparser
> Reporter: Chris Male
> Attachments: LUCENE-3284.patch
>
>
> Some contribs and modules depend on the core QueryParser just for simplicity in their tests. We should apply the same process as I did to the core tests, and move them away from using the QueryParser where possible.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3284) Move contribs/modules away from
QueryParser dependency
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male updated LUCENE-3284:
-------------------------------
Attachment: LUCENE-3284.patch
Patch which removes the QP dependency from the queries module and from highlighter.
The only other module which depends on QP in its test is analysis-common, which combines some complex analysis with some reasonably complex queries. Consequently I will leave this till later when we can examine the QP needs for the analysis module in general.
> Move contribs/modules away from QueryParser dependency
> ------------------------------------------------------
>
> Key: LUCENE-3284
> URL: https://issues.apache.org/jira/browse/LUCENE-3284
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/queryparser, modules/queryparser
> Reporter: Chris Male
> Attachments: LUCENE-3284.patch
>
>
> Some contribs and modules depend on the core QueryParser just for simplicity in their tests. We should apply the same process as I did to the core tests, and move them away from using the QueryParser where possible.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3284) Move contribs/modules away from
QueryParser dependency
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male updated LUCENE-3284:
-------------------------------
Attachment: LUCENE-3284.patch
New patch which also addresses the analysis-common dependencies.
In both situations Querys were being created and executed needlessly instead of assertions being made on the contents of the tokenstream.
In the case of the ShingleAnalyzerWrapperTest, some tests were dependent on the behavior of QueryParser and therefore were tests of QP parsing.
This is ready to go.
> Move contribs/modules away from QueryParser dependency
> ------------------------------------------------------
>
> Key: LUCENE-3284
> URL: https://issues.apache.org/jira/browse/LUCENE-3284
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/queryparser, modules/queryparser
> Reporter: Chris Male
> Attachments: LUCENE-3284.patch, LUCENE-3284.patch
>
>
> Some contribs and modules depend on the core QueryParser just for simplicity in their tests. We should apply the same process as I did to the core tests, and move them away from using the QueryParser where possible.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3284) Move contribs/modules away from
QueryParser dependency
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male resolved LUCENE-3284.
--------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Assignee: Chris Male
Committed revision 1144566.
> Move contribs/modules away from QueryParser dependency
> ------------------------------------------------------
>
> Key: LUCENE-3284
> URL: https://issues.apache.org/jira/browse/LUCENE-3284
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/queryparser, modules/queryparser
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3284.patch, LUCENE-3284.patch
>
>
> Some contribs and modules depend on the core QueryParser just for simplicity in their tests. We should apply the same process as I did to the core tests, and move them away from using the QueryParser where possible.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org