[GitHub] [iceberg] kbendick edited a comment on pull request #3642: build: remove slf4j-api from dependency recommender

[GitBox <gi...@apache.org>]

kbendick edited a comment on pull request #3642:
URL: https://github.com/apache/iceberg/pull/3642#issuecomment-986298996


   > > Have we checked if this is just with the generated pom for the SNAPSHOT? That is, has anybody checked about doing —packages with 0.12.1 with a clean install (so not in local maven pre-fetched)? I’ll do that tomorrow if no one has (it’s late for me), but if it’s not needed for the normal release process, I’d prefer to see if there’s a way to handle it vs having to version just for the snapshot.
   > 
   > 0.12.1 works fine for me. Maybe this is related to splitting spark support in different versions, which came after 0.12.1
   
   Thinking on it further, 0.12.1 wouldn't be affected as we cherry-picked commits into it, and so 0.12.1 technically predates the repo reorganization. Also, 0.12.1 doesn't have Spark 3.2 on it.
   
   I took a closer look at the link and it recommends using another nebula dependency tool for generating the POM. Are we already using `nebula.maven-resolved-dependencies`? I took a look and didn't see that specific one anywhere. That might be the better fix for the SNAPSHOT release.
   
   From the link in the PR description: `Gradle requires that version numbers are present in the dependencies block to create a valid POM file that includes version numbers. To fix the issue this causes when using the dependency-recommender plug-in, apply the nebula.maven-resolved-dependencies plug-in from the nebula-publishing-plugin set.`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org