[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #707: Allows Java-style property names in Log4j 1.x XML configuration

[GitBox <gi...@apache.org>]

ppkarwasz opened a new pull request #707:
URL: https://github.com/apache/logging-log4j2/pull/707


   Log4j 1.x allows for both capitalized (`InfoLocation`) and Java-style (`infoLocation`) component property names (`PropertySetter` calls `Introspector.decapitalize`). This PR allows for Java-style property names in the Log4j 1.x bridge. It also fixes some capitalization typos (e.g. `target` instead of `Target`).
   
   This fixes most XML tests from #706 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #707: Allows Java-style property names in Log4j 1.x XML configuration

[GitBox <gi...@apache.org>]

ppkarwasz commented on pull request #707:
URL: https://github.com/apache/logging-log4j2/pull/707#issuecomment-1017542712


   @garydgregory 
   Looks great and since `AbstractLog4j1ConfigurationTest` is in the repository now, I can rebase the remaining PRs on top of your commit. This will reduce the size of the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] garydgregory commented on pull request #707: Allows Java-style property names in Log4j 1.x XML configuration

[GitBox <gi...@apache.org>]

garydgregory commented on pull request #707:
URL: https://github.com/apache/logging-log4j2/pull/707#issuecomment-1017505827


   @ppkarwasz 
   Thank you for your PR! It turns out I had an implementation in flight similar to this PR. Please see the latest from git. You are credited in changes.xml, as I was able to bring in all of these test changes as is. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] garydgregory closed pull request #707: Allows Java-style property names in Log4j 1.x XML configuration

[GitBox <gi...@apache.org>]

garydgregory closed pull request #707:
URL: https://github.com/apache/logging-log4j2/pull/707


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] garydgregory commented on pull request #707: Allows Java-style property names in Log4j 1.x XML configuration

[GitBox <gi...@apache.org>]

garydgregory commented on pull request #707:
URL: https://github.com/apache/logging-log4j2/pull/707#issuecomment-1014536381


   Hi @ppkarwasz 
   You need tests to fail without these main changes to show the main changes actually fix something. Otherwise, future changes might just reintroduce the old behavior unbeknownst to anyone.
   TY!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org