You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by gr...@apache.org on 2018/09/21 22:40:21 UTC

[mesos] branch master updated: Fixed flaky test `RemoveExecutorUponFailedLaunch`.

This is an automated email from the ASF dual-hosted git repository.

grag pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git


The following commit(s) were added to refs/heads/master by this push:
     new cacc055  Fixed flaky test `RemoveExecutorUponFailedLaunch`.
cacc055 is described below

commit cacc0556b7d870028c7abd2ffa5b47f6b493da55
Author: Meng Zhu <mz...@mesosphere.io>
AuthorDate: Fri Sep 21 15:15:04 2018 -0700

    Fixed flaky test `RemoveExecutorUponFailedLaunch`.
    
    The scheduler `statusUpdate` call expectation is not
    necessary and may not be satisfied in some cases, leading
    to flakiness. Replaced `WillOnce` with `AtMost(1)`.
    
    Review: https://reviews.apache.org/r/68803/
---
 src/tests/slave_tests.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/tests/slave_tests.cpp b/src/tests/slave_tests.cpp
index 9597067..637bedc 100644
--- a/src/tests/slave_tests.cpp
+++ b/src/tests/slave_tests.cpp
@@ -4584,9 +4584,8 @@ TEST_F(SlaveTest, RemoveExecutorUponFailedLaunch)
   EXPECT_CALL(exec, registered(_, _, _, _))
     .Times(0);
 
-  Future<TaskStatus> killTaskStatus;
   EXPECT_CALL(sched, statusUpdate(&driver, _))
-    .WillOnce(FutureArg<1>(&killTaskStatus));
+    .Times(AtMost(1));
 
   Future<ExitedExecutorMessage> exitedExecutorMessage =
     FUTURE_PROTOBUF(ExitedExecutorMessage(), _, _);