You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/05/24 07:15:05 UTC
[GitHub] [incubator-tvm] roastduck opened a new pull request #5665: [Arith] Handle likely in IRMutatorWithAnalyzer
roastduck opened a new pull request #5665:
URL: https://github.com/apache/incubator-tvm/pull/5665
For `if (likely(x))`, `x` rather than `likely(x)` should be fed into the analyzer as a constraint.
This changes helps `tir.transform.Simplify` simplify
```
// attr [iter_var(threadIdx.x, , threadIdx.x)] thread_extent = 32
// attr [iter_var(threadIdx.y, , threadIdx.y)] thread_extent = 32
if (likely((((threadIdx.x*32) + threadIdx.y) < {n|n>=0}))) {
if (likely((((threadIdx.x*32) + threadIdx.y) < {n|n>=0}))) {
A[threadIdx.x] = C[((threadIdx.x*32) + threadIdx.y)]
}
}
```
into
```
// attr [iter_var(threadIdx.x, , threadIdx.x)] thread_extent = 32
// attr [iter_var(threadIdx.y, , threadIdx.y)] thread_extent = 32
if (likely((((threadIdx.x*32) + threadIdx.y) < {n|n>=0}))) {
A[threadIdx.x] = C[((threadIdx.x*32) + threadIdx.y)]
}
```
I added this case as a new test.
@tqchen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] roastduck closed pull request #5665: [Arith] Handle likely in IRMutatorWithAnalyzer
Posted by GitBox <gi...@apache.org>.
roastduck closed pull request #5665:
URL: https://github.com/apache/incubator-tvm/pull/5665
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #5665: [Arith] Handle likely in IRMutatorWithAnalyzer
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5665:
URL: https://github.com/apache/incubator-tvm/pull/5665
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5665: [Arith] Handle likely in IRMutatorWithAnalyzer
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5665:
URL: https://github.com/apache/incubator-tvm/pull/5665#issuecomment-633259549
Please try to retrigger as the error was a flaky one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5665: [Arith] Handle likely in IRMutatorWithAnalyzer
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #5665:
URL: https://github.com/apache/incubator-tvm/pull/5665#issuecomment-633259549
Please try to retrigger as the error was a flaky one https://github.com/apache/incubator-tvm/issues/5667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5665: [Arith] Handle likely in IRMutatorWithAnalyzer
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5665:
URL: https://github.com/apache/incubator-tvm/pull/5665#issuecomment-633646993
Thanks @roastduck !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org