You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2020/05/19 00:23:19 UTC
[GitHub] [mesos] bmahler commented on pull request #365: Fix FreeBSD memory detection (MESOS-10104)
bmahler commented on pull request #365:
URL: https://github.com/apache/mesos/pull/365#issuecomment-630503075
@Digital-Chaos thanks for fixing this!
Whoops, looks like we don't have any unit tests for os::memory()! Could you add some here to ensure this fix is covered by tests:
https://github.com/apache/mesos/blob/1.9.0/3rdparty/stout/tests/os_tests.cpp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org