[GitHub] [flink] fapaul commented on a change in pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors

[GitBox <gi...@apache.org>]

fapaul commented on a change in pull request #17459:
URL: https://github.com/apache/flink/pull/17459#discussion_r727142712



##########
File path: flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/table/HBaseConnectorOptionsUtil.java
##########
@@ -57,8 +58,8 @@
      * type columns in the schema. The PRIMARY KEY constraint is optional, if exist, the primary key
      * constraint must be defined on the single row key field.
      */
-    public static void validatePrimaryKey(TableSchema schema) {
-        HBaseTableSchema hbaseSchema = HBaseTableSchema.fromTableSchema(schema);
+    public static void validatePrimaryKey(DataType dataType, Schema schema) {

Review comment:
       The method requires knowledge about the primary key. AFAIK `DataType` does not offer such information. The only other option here would be to pass a `ResolvedSchema` (not sure that works for all the callers)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org