[GitHub] [spark] cloud-fan commented on pull request #31199: [SPARK-34130][SQL] Impove preformace for char varchar padding and length check with StaticInvoke

[GitBox <gi...@apache.org>]

cloud-fan commented on pull request #31199:
URL: https://github.com/apache/spark/pull/31199#issuecomment-762632317


   Ideally, we shouldn't backport perf improvement, but not passing `TPCDSQuerySuite` with char/varchar in table schema concerns me (see https://github.com/apache/spark/pull/31012). Since it only touches the char/varchar code path, I feel it's safe and better to have this "fix" in branch-3.1 as well. I won't treat it as a blocker though (won't fail rc1).
   
   @HyukjinKwon what do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org