You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2018/04/19 17:38:52 UTC

[Impala-ASF-CR] IMPALA-6884: Skip test misaligned orc stripes on invalid platforms

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10117


Change subject: IMPALA-6884: Skip test_misaligned_orc_stripes on invalid platforms
......................................................................

IMPALA-6884: Skip test_misaligned_orc_stripes on invalid platforms

test_misaligned_orc_stripes relies on generating files
with a specific number of HDFS blocks. This is not
possible on S3, ADLS, or Isilon, so the test needs to
be skipped on those platforms. Additionally, it relies
on running multiple impalads, so it needs to be skipped
on local filesystem tests.

Change-Id: I8395b4eb06847a35c630b3ef43e289960d78382a
---
M tests/query_test/test_scanners.py
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/10117/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8395b4eb06847a35c630b3ef43e289960d78382a
Gerrit-Change-Number: 10117
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-6884: Skip test misaligned orc stripes on invalid platforms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10117 )

Change subject: IMPALA-6884: Skip test_misaligned_orc_stripes on invalid platforms
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8395b4eb06847a35c630b3ef43e289960d78382a
Gerrit-Change-Number: 10117
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 21:58:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6884: Skip test misaligned orc stripes on invalid platforms

Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10117 )

Change subject: IMPALA-6884: Skip test_misaligned_orc_stripes on invalid platforms
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8395b4eb06847a35c630b3ef43e289960d78382a
Gerrit-Change-Number: 10117
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 17:44:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6884: Skip test misaligned orc stripes on invalid platforms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10117 )

Change subject: IMPALA-6884: Skip test_misaligned_orc_stripes on invalid platforms
......................................................................

IMPALA-6884: Skip test_misaligned_orc_stripes on invalid platforms

test_misaligned_orc_stripes relies on generating files
with a specific number of HDFS blocks. This is not
possible on S3, ADLS, or Isilon, so the test needs to
be skipped on those platforms. Additionally, it relies
on running multiple impalads, so it needs to be skipped
on local filesystem tests.

Change-Id: I8395b4eb06847a35c630b3ef43e289960d78382a
Reviewed-on: http://gerrit.cloudera.org:8080/10117
Reviewed-by: Vuk Ercegovac <ve...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_scanners.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Vuk Ercegovac: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8395b4eb06847a35c630b3ef43e289960d78382a
Gerrit-Change-Number: 10117
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>

[Impala-ASF-CR] IMPALA-6884: Skip test misaligned orc stripes on invalid platforms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10117 )

Change subject: IMPALA-6884: Skip test_misaligned_orc_stripes on invalid platforms
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2335/


-- 
To view, visit http://gerrit.cloudera.org:8080/10117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8395b4eb06847a35c630b3ef43e289960d78382a
Gerrit-Change-Number: 10117
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 17:59:49 +0000
Gerrit-HasComments: No