You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2025/09/08 07:06:35 UTC
[PR] Add NetBeansProjects dir to Favorites tab [netbeans]
mbien opened a new pull request, #8798:
URL: https://github.com/apache/netbeans/pull/8798
- projects dir is now registered as favorite (after user home)
- fixed bug: when a custom project dir location is specified by setting `netbeans.projects.dir`, the dir is now automatically created, instead of falling back to the default dir, which gave the impression that the property isn't working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#discussion_r2340576891
##########
ide/projectui/src/org/netbeans/modules/project/ui/resources/layer.xml:
##########
@@ -130,6 +130,14 @@
</folder>
</folder>
+ <folder name="Favorites">
+ <file name="NetBeansProjects.shadow">
Review Comment:
we would have to check if renaming nodes still works, because favorites renames the virtual top level nodes instead of the files. Not sure what will happen when it uses the display name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#issuecomment-4244596123
rebased without changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#issuecomment-3938244255
Wondering if we should try to get this in for NB 30 given recent improvements (https://github.com/apache/netbeans/pull/9186)?
`nb/ide.branding` is only for the IDE, so I believe this wouldn't affect platform apps at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#discussion_r2329335473
##########
ide/projectui/src/org/netbeans/modules/project/ui/resources/layer.xml:
##########
@@ -130,6 +130,14 @@
</folder>
</folder>
+ <folder name="Favorites">
+ <file name="NetBeansProjects.shadow">
Review Comment:
note: i couldn't figure out how to put the display name of "NetBeansProjects" into the bundle. It did change the name within the layer tree, but didn't change within the Favorites tab. I believe "Home" is also not localized unless I overlooked something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#issuecomment-3280117720
I think this is a good change, and probably OK, as long as it's configurable for platform applications.
Mixed feelings about whether Favorites nodes needs to support localization / branding first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#issuecomment-3280345535
regarding display name: we would have to check if renaming nodes still works, because favorites renames the virtual top level nodes instead of the files. Not sure what will happen when it uses the display name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #8798:
URL: https://github.com/apache/netbeans/pull/8798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#issuecomment-3487118723
the layer registration moved to `nb/ide.branding`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#discussion_r2341379034
##########
ide/projectui/src/org/netbeans/modules/project/ui/resources/layer.xml:
##########
@@ -130,6 +130,14 @@
</folder>
</folder>
+ <folder name="Favorites">
+ <file name="NetBeansProjects.shadow">
Review Comment:
Yes, worth making sure. As it changes the name of the shadow (symlink) then hopefully. Forgot to check when playing with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#discussion_r2347165452
##########
ide/projectui/src/org/netbeans/modules/project/ui/resources/layer.xml:
##########
@@ -130,6 +130,14 @@
</folder>
</folder>
+ <folder name="Favorites">
+ <file name="NetBeansProjects.shadow">
Review Comment:
I checked and it would rename the virtual file without the display name.
the current `Home` node registration is:
https://github.com/apache/netbeans/blob/3860d48919661e9f62a93e77cd5599f52716e634/platform/favorites/src/org/netbeans/modules/favorites/resources/layer.xml#L24-L31
renaming `Home` using NB 27 works, but if we would render the display name (e.g `HOME42`), it would no longer make the update visible and it will keep showing `HOME42`.
Changing the impl might be a bit too risky for the scope of this PR - who knows what relied on this. I suppose platform applications could remove the item via their layer somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#issuecomment-3399989264
had no ideas how to easily "brand" this so that this is only enabled in the IDE. Will probably move this to NB 29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#discussion_r2340333090
##########
ide/projectui/src/org/netbeans/modules/project/ui/resources/layer.xml:
##########
@@ -130,6 +130,14 @@
</folder>
</folder>
+ <folder name="Favorites">
+ <file name="NetBeansProjects.shadow">
Review Comment:
The lines -
https://github.com/apache/netbeans/blob/d10bf812d744914b323ab01d5266bf4e836de602/platform/favorites/src/org/netbeans/modules/favorites/FavoritesNode.java#L499
https://github.com/apache/netbeans/blob/d10bf812d744914b323ab01d5266bf4e836de602/platform/favorites/src/org/netbeans/modules/favorites/FavoritesNode.java#L515
changed to
```java
String name = super.getDisplayName();
```
should do this. Pros and cons, although matching the value of
https://github.com/apache/netbeans/blob/d10bf812d744914b323ab01d5266bf4e836de602/ide/projectui/src/org/netbeans/modules/project/ui/Bundle.properties#L208
would be desirable for platform apps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#discussion_r2329335473
##########
ide/projectui/src/org/netbeans/modules/project/ui/resources/layer.xml:
##########
@@ -130,6 +130,14 @@
</folder>
</folder>
+ <folder name="Favorites">
+ <file name="NetBeansProjects.shadow">
Review Comment:
note: i couldn't figure out how to put the display name of "NetBeansProjects" into the bundle. It did change the name within the layer tree, but didn't change within the Favorites tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#issuecomment-3280267747
> And a somewhat tangential question - should we show Favorites rather than Services in the default window setup?
Yep, as mentioned somewhere else I think we should open it by default in the same tab group as Projects/Files/Favorites. But its probably something to discuss first on the dev list first?
Might be even good to open Favorites with the first file if we can figure out how to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add NetBeansProjects dir to Favorites tab [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#issuecomment-3749122205
dropped the milestone on this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists