You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "thiagoelg (via GitHub)" <gi...@apache.org> on 2026/01/29 21:10:46 UTC
[PR] kie-issues#2232: Upgrade Node.js to 24.13.0 and pnpm to 10.28.2 [incubator-kie-tools]
thiagoelg opened a new pull request, #3414:
URL: https://github.com/apache/incubator-kie-tools/pull/3414
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2232: Upgrade Node.js to 24.13.0 and pnpm to 10.28.2 [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on PR #3414:
URL: https://github.com/apache/incubator-kie-tools/pull/3414#issuecomment-3860749506
The `strict: true` option introduces additional rules beyond those 3: https://www.typescriptlang.org/tsconfig/#strict.
I would like to be stricter with TypeScript, but maybe in a future PR.
Thank you for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2232: Upgrade Node.js to 24.13.0 and pnpm to 10.28.2 [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3414:
URL: https://github.com/apache/incubator-kie-tools/pull/3414#discussion_r2746743082
##########
packages/python-venv/patches/cekit@4.15.0.patch:
##########
Review Comment:
I'll remove this once CEKit publishes a new version (see https://github.com/cekit/cekit/pull/952)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2232: Upgrade Node.js to 24.13.0 and pnpm to 10.28.2 [incubator-kie-tools]
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #3414:
URL: https://github.com/apache/incubator-kie-tools/pull/3414#discussion_r2743812380
##########
packages/eslint/eslint.js:
##########
@@ -38,10 +39,13 @@
}
try {
- execSync(`pnpm eslint ${lintPath} --ext .ts,.tsx --config ${configPath} ${ignorePathArgument}`, {
- stdio: "inherit",
- cwd: __dirname,
- });
+ execSync(
+ `pnpm eslint ${lintPath} --ext .ts,.tsx --config ${configPath} --resolve-plugins-relative-to ${defaultConfigPath} ${ignorePathArgument}`,
Review Comment:
## Shell command built from environment values
This shell command depends on an uncontrolled [absolute path](1).
This shell command depends on an uncontrolled [absolute path](2).
This shell command depends on an uncontrolled [absolute path](3).
[Show more details](https://github.com/apache/incubator-kie-tools/security/code-scanning/1046)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2232: Upgrade Node.js to 24.13.0 and pnpm to 10.28.2 [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3414:
URL: https://github.com/apache/incubator-kie-tools/pull/3414#discussion_r2754448718
##########
packages/extended-services/package.json:
##########
@@ -45,9 +45,9 @@
"powershell": "@powershell -NoProfile -ExecutionPolicy Unrestricted -Command",
"start": "cross-env ENV=dev make start",
"unpack:mvn:jitexecutor-native": "run-script-os",
- "unpack:mvn:jitexecutor-native:darwin": "mvn dependency:unpack -DoutputDirectory=dist-dev -Dartifact=\"org.kie.kogito:jitexecutor-native-darwin:999-20250511-SNAPSHOT:jar:binaries\"",
- "unpack:mvn:jitexecutor-native:linux": "mvn dependency:unpack -DoutputDirectory=dist-dev -Dartifact=\"org.kie.kogito:jitexecutor-native-linux:999-20250511-SNAPSHOT:jar:binaries\"",
- "unpack:mvn:jitexecutor-native:win32": "pnpm powershell \"mvn dependency:unpack `-DoutputDirectory=dist-dev `-Dartifact=org.kie.kogito:jitexecutor-native-win32:999-20250511-SNAPSHOT:jar:binaries\""
+ "unpack:mvn:jitexecutor-native:darwin": "mvn clean dependency:unpack -DoutputDirectory=dist-dev -Dartifact=\"org.kie.kogito:jitexecutor-native-darwin:999-20250511-SNAPSHOT:jar:binaries\"",
+ "unpack:mvn:jitexecutor-native:linux": "mvn clean dependency:unpack -DoutputDirectory=dist-dev -Dartifact=\"org.kie.kogito:jitexecutor-native-linux:999-20250511-SNAPSHOT:jar:binaries\"",
Review Comment:
@thiagoelg Not related to your changes... but it's weird we are pointing to that (old) snapshot of the jit-executor :o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2232: Upgrade Node.js to 24.13.0 and pnpm to 10.28.2 [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3414:
URL: https://github.com/apache/incubator-kie-tools/pull/3414#discussion_r2754773229
##########
packages/extended-services/package.json:
##########
@@ -45,9 +45,9 @@
"powershell": "@powershell -NoProfile -ExecutionPolicy Unrestricted -Command",
"start": "cross-env ENV=dev make start",
"unpack:mvn:jitexecutor-native": "run-script-os",
- "unpack:mvn:jitexecutor-native:darwin": "mvn dependency:unpack -DoutputDirectory=dist-dev -Dartifact=\"org.kie.kogito:jitexecutor-native-darwin:999-20250511-SNAPSHOT:jar:binaries\"",
- "unpack:mvn:jitexecutor-native:linux": "mvn dependency:unpack -DoutputDirectory=dist-dev -Dartifact=\"org.kie.kogito:jitexecutor-native-linux:999-20250511-SNAPSHOT:jar:binaries\"",
- "unpack:mvn:jitexecutor-native:win32": "pnpm powershell \"mvn dependency:unpack `-DoutputDirectory=dist-dev `-Dartifact=org.kie.kogito:jitexecutor-native-win32:999-20250511-SNAPSHOT:jar:binaries\""
+ "unpack:mvn:jitexecutor-native:darwin": "mvn clean dependency:unpack -DoutputDirectory=dist-dev -Dartifact=\"org.kie.kogito:jitexecutor-native-darwin:999-20250511-SNAPSHOT:jar:binaries\"",
+ "unpack:mvn:jitexecutor-native:linux": "mvn clean dependency:unpack -DoutputDirectory=dist-dev -Dartifact=\"org.kie.kogito:jitexecutor-native-linux:999-20250511-SNAPSHOT:jar:binaries\"",
Review Comment:
I know... but it's the latest one available (https://repository.apache.org/content/groups/snapshots/org/kie/kogito/jitexecutor-native-darwin/). Did we stopped publishing it at some point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2232: Upgrade Node.js to 24.13.0 and pnpm to 10.28.2 [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3414:
URL: https://github.com/apache/incubator-kie-tools/pull/3414#discussion_r2754773229
##########
packages/extended-services/package.json:
##########
@@ -45,9 +45,9 @@
"powershell": "@powershell -NoProfile -ExecutionPolicy Unrestricted -Command",
"start": "cross-env ENV=dev make start",
"unpack:mvn:jitexecutor-native": "run-script-os",
- "unpack:mvn:jitexecutor-native:darwin": "mvn dependency:unpack -DoutputDirectory=dist-dev -Dartifact=\"org.kie.kogito:jitexecutor-native-darwin:999-20250511-SNAPSHOT:jar:binaries\"",
- "unpack:mvn:jitexecutor-native:linux": "mvn dependency:unpack -DoutputDirectory=dist-dev -Dartifact=\"org.kie.kogito:jitexecutor-native-linux:999-20250511-SNAPSHOT:jar:binaries\"",
- "unpack:mvn:jitexecutor-native:win32": "pnpm powershell \"mvn dependency:unpack `-DoutputDirectory=dist-dev `-Dartifact=org.kie.kogito:jitexecutor-native-win32:999-20250511-SNAPSHOT:jar:binaries\""
+ "unpack:mvn:jitexecutor-native:darwin": "mvn clean dependency:unpack -DoutputDirectory=dist-dev -Dartifact=\"org.kie.kogito:jitexecutor-native-darwin:999-20250511-SNAPSHOT:jar:binaries\"",
+ "unpack:mvn:jitexecutor-native:linux": "mvn clean dependency:unpack -DoutputDirectory=dist-dev -Dartifact=\"org.kie.kogito:jitexecutor-native-linux:999-20250511-SNAPSHOT:jar:binaries\"",
Review Comment:
I know... but it's the latest one available (https://repository.apache.org/content/groups/snapshots/org/kie/kogito/jitexecutor-native-darwin/).
Did we stop publishing it at some point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2232: Upgrade Node.js to 24.13.0 and pnpm to 10.28.2 [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #3414:
URL: https://github.com/apache/incubator-kie-tools/pull/3414#issuecomment-3862135294
Thank you @thiagoelg. Much needed work and at a very welcome timing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2232: Upgrade Node.js to 24.13.0 and pnpm to 10.29.2 [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg merged PR #3414:
URL: https://github.com/apache/incubator-kie-tools/pull/3414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org