You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/06 14:13:56 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #10828: MINOR: Only log overridden topic configs during topic creation

ijuma commented on a change in pull request #10828:
URL: https://github.com/apache/kafka/pull/10828#discussion_r646138828



##########
File path: core/src/test/scala/unit/kafka/log/LogConfigTest.scala
##########
@@ -162,6 +162,21 @@ class LogConfigTest {
     assertNull(nullServerDefault)
   }
 
+  @Test
+  def testOverriddenConfigsAsLoggableString(): Unit = {
+    val kafkaProps = TestUtils.createBrokerConfig(nodeId = 0, zkConnect = "")
+    kafkaProps.put("unknown.broker.password.config", "aaaaa")
+    kafkaProps.put(KafkaConfig.SslKeyPasswordProp, "somekeypassword")

Review comment:
       Yes, we can. The goal of this test is not to verify that, but no harm in covering it too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org