You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Marcus Eriksson (JIRA)" <ji...@apache.org> on 2012/06/21 14:31:42 UTC
[jira] [Created] (CASSANDRA-4364) Compaction invalidates row cache
Marcus Eriksson created CASSANDRA-4364:
------------------------------------------
Summary: Compaction invalidates row cache
Key: CASSANDRA-4364
URL: https://issues.apache.org/jira/browse/CASSANDRA-4364
Project: Cassandra
Issue Type: Bug
Affects Versions: 1.2
Reporter: Marcus Eriksson
Priority: Minor
Compactions invalidate row cache after CASSANDRA-3862
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/CompactionIterable.java#L87
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4364) Compaction invalidates row
cache
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399169#comment-13399169 ]
Sylvain Lebresne commented on CASSANDRA-4364:
---------------------------------------------
I think that at the very least we could simply remove expired tombstones for the in-heap cache as we were doing before. At least I don't understand why that was removing since I don't see a problem with that. For the off-heap cache, I guess the choice is between keeping the invalidation or leaving the expired tombstone in cache. Not sure what is best, it will probably depend a bit on the use cases, but my hunch is that just leaving the tombstone in cache is probably a win most of the time.
> Compaction invalidates row cache
> --------------------------------
>
> Key: CASSANDRA-4364
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4364
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.2
> Reporter: Marcus Eriksson
> Priority: Minor
>
> Compactions invalidate row cache after CASSANDRA-3862
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/CompactionIterable.java#L87
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4364) Compaction invalidates row cache
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-4364:
----------------------------------------
Affects Version/s: (was: 1.2.0 beta 1)
1.1.3
> Compaction invalidates row cache
> --------------------------------
>
> Key: CASSANDRA-4364
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4364
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.3
> Reporter: Marcus Eriksson
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: compaction
> Fix For: 1.2.0 beta 1
>
> Attachments: 4364.txt
>
>
> Compactions invalidate row cache after CASSANDRA-3862
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/CompactionIterable.java#L87
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4364) Compaction invalidates row
cache
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398705#comment-13398705 ]
Jonathan Ellis commented on CASSANDRA-4364:
-------------------------------------------
What do you sugggest instead?
> Compaction invalidates row cache
> --------------------------------
>
> Key: CASSANDRA-4364
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4364
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.2
> Reporter: Marcus Eriksson
> Priority: Minor
>
> Compactions invalidate row cache after CASSANDRA-3862
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/CompactionIterable.java#L87
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4364) Compaction invalidates row cache
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-4364:
----------------------------------------
Fix Version/s: (was: 1.1.3)
1.2.0 beta 1
> Compaction invalidates row cache
> --------------------------------
>
> Key: CASSANDRA-4364
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4364
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.3
> Reporter: Marcus Eriksson
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: compaction
> Fix For: 1.2.0 beta 1
>
> Attachments: 4364.txt
>
>
> Compactions invalidate row cache after CASSANDRA-3862
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/CompactionIterable.java#L87
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4364) Compaction invalidates row
cache
Posted by "Robert Coli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497690#comment-13497690 ]
Robert Coli commented on CASSANDRA-4364:
----------------------------------------
Affects Version/s: 1.2.0 beta 1
Fix Version/s: 1.1.3
It affects versions after the version it was fixed in? Seems unlikely? Are these transposed? :)
> Compaction invalidates row cache
> --------------------------------
>
> Key: CASSANDRA-4364
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4364
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.2.0 beta 1
> Reporter: Marcus Eriksson
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: compaction
> Fix For: 1.1.3
>
> Attachments: 4364.txt
>
>
> Compactions invalidate row cache after CASSANDRA-3862
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/CompactionIterable.java#L87
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4364) Compaction invalidates row cache
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4364:
--------------------------------------
Attachment: 4364.txt
Agreed, the earlier compromise (removeDeletedInCache for on-heap cache; ignore for serializing) is probably best. Patch attached to restore that.
See CASSANDRA-2304 and CASSANDRA-3921 for more background.
> Compaction invalidates row cache
> --------------------------------
>
> Key: CASSANDRA-4364
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4364
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.2
> Reporter: Marcus Eriksson
> Priority: Minor
> Labels: compaction
> Fix For: 1.1.3
>
> Attachments: 4364.txt
>
>
> Compactions invalidate row cache after CASSANDRA-3862
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/CompactionIterable.java#L87
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4364) Compaction invalidates row
cache
Posted by "Marcus Eriksson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398724#comment-13398724 ]
Marcus Eriksson commented on CASSANDRA-4364:
--------------------------------------------
we discussed this a bit on irc, and the reason that the cached rows were invalidated was to get rid of expired tombstones in the cached rows
maybe it is not a big deal to just leave them there?
> Compaction invalidates row cache
> --------------------------------
>
> Key: CASSANDRA-4364
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4364
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.2
> Reporter: Marcus Eriksson
> Priority: Minor
>
> Compactions invalidate row cache after CASSANDRA-3862
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/CompactionIterable.java#L87
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4364) Compaction invalidates row
cache
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404901#comment-13404901 ]
Sylvain Lebresne commented on CASSANDRA-4364:
---------------------------------------------
+1
> Compaction invalidates row cache
> --------------------------------
>
> Key: CASSANDRA-4364
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4364
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.2
> Reporter: Marcus Eriksson
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: compaction
> Fix For: 1.1.3
>
> Attachments: 4364.txt
>
>
> Compactions invalidate row cache after CASSANDRA-3862
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/CompactionIterable.java#L87
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira