You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2021/05/07 13:41:00 UTC
[jira] [Commented] (HBASE-25851) Make LoadBalancer not extend
Configurable interface
[ https://issues.apache.org/jira/browse/HBASE-25851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340841#comment-17340841 ]
Hudson commented on HBASE-25851:
--------------------------------
Results for branch master
[build #285 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/285/]: (/) *{color:green}+1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/285/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/285/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/285/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make LoadBalancer not extend Configurable interface
> ---------------------------------------------------
>
> Key: HBASE-25851
> URL: https://issues.apache.org/jira/browse/HBASE-25851
> Project: HBase
> Issue Type: Sub-task
> Components: Balancer
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> On master, LoadBalancer has a setClusterInfoProvider method and on branch-2, LoadBalancer has a setMasterServices method. Both ClusterInfoProvider and MasterServices could give a Configuration out so I do not think we need to expose another setConf method.
> When refactoring StochasticLoadBalancer, the initialization order is also a pain as after setConf, we will load a lot of configuration but at that time, the ClusterInfoProvider is not present, and easy to cause NPE...
> And it could also help simplity locking.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)