You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/19 08:45:23 UTC
[GitHub] [flink] fpompermaier commented on a change in pull request #12090: [FLINK-17622][connectors / jdbc] Remove useless switch for decimal in PostgresCatalog
fpompermaier commented on a change in pull request #12090:
URL: https://github.com/apache/flink/pull/12090#discussion_r427132837
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/PostgresCatalog.java
##########
@@ -258,6 +256,8 @@ private DataType fromJDBCType(ResultSetMetaData metadata, int colIndex) throws S
int precision = metadata.getPrecision(colIndex);
int scale = metadata.getScale(colIndex);
+ // pg types that gets replaced by jdbc driver:
+ // - decimal => numeric
Review comment:
I wanted to add the other comments in the other PR (pr #11900) to support serial fields..but I can list all of them here and avoid to add some of them in the other PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org