You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/07/12 13:27:10 UTC
[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #39: Fix stack overflow when parsing lists
mocobeta opened a new pull request, #39:
URL: https://github.com/apache/lucene-jira-archive/pull/39
Close #38
This ad-hoc patch fixes `'maximum recursion depth exceeded'` error, and also makes the script a bit faster. (8h -> 5h)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #39: Stack overflows can occur when parsing Jira lists
Posted by GitBox <gi...@apache.org>.
mikemccand commented on code in PR #39:
URL: https://github.com/apache/lucene-jira-archive/pull/39#discussion_r919015037
##########
migration/src/markup/lists.py:
##########
@@ -40,6 +40,11 @@ def action(self, tokens: ParseResults) -> str:
for line in tokens:
# print(repr(line))
+ if line == "\n":
+ # can't really explain but if this is the first item, an empty string should be added to preserve line feed
Review Comment:
LOL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on pull request #39: Stack overflows can occur when parsing Jira lists
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #39:
URL: https://github.com/apache/lucene-jira-archive/pull/39#issuecomment-1181804695
Thank you @mikemccand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta merged pull request #39: Stack overflows can occur when parsing Jira lists
Posted by GitBox <gi...@apache.org>.
mocobeta merged PR #39:
URL: https://github.com/apache/lucene-jira-archive/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org